fix: adapt update_wrapper to the reworked airbender CLI - #31
Draft
antonbaliasnikov wants to merge 1 commit into
Draft
fix: adapt update_wrapper to the reworked airbender CLI#31antonbaliasnikov wants to merge 1 commit into
antonbaliasnikov wants to merge 1 commit into
Conversation
The airbender CLI was reworked (zksync-airbender PR #220): `prove` no longer accepts `--until final-proof` or `--final-proof-name`, so the proof-generation step failed with an argument-parsing error against any airbender checkout carrying the rework (including the FRI-fix branch the wrapper now pins). Adapt the step to the new interface and fixture layout: - prove with `--security-level 100` and `--output-file`; the new CLI defaults to the recursion-unified target, which is the old final proof - extract the bare UnrolledProgramProof from the ProofArtifact JSON the CLI now writes (the wrapper tests consume the bare proof, not the metadata-wrapped artifact) - write it to risc_proof_100sb — fixtures are now per-security-level, and CI runs the wrapper tests at security_100 (the default feature) - convert JSON to bincode in place via the wrapper's checked-in convert_risc_proof_from_json helper test, matching the bincode format the tests read since the json -> bin fixture migration Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
antonbaliasnikov
marked this pull request as draft
August 27, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What ❔
Fixes the proof-generation step of
scripts/update_wrapper.py, which fails against any airbender checkout carrying the CLI rework (zksync-airbender PR #220) — including thedi/fix/87680-fri-fix-devbranch the wrapper currently pins.proveno longer accepts--until final-proof/--final-proof-name; the new interface uses--output-file, defaults to therecursion-unifiedtarget (the old "final proof"), and takes an explicit--security-level.ProofArtifactJSON (metadata wrapping the proof), while the wrapper tests read a bincode-encoded bareUnrolledProgramProof— the script now extracts the inner proof and converts it in place via the wrapper's checked-inconvert_risc_proof_from_jsonhelper test.risc_proof_100sb, matching what CI's wrapper tests consume (security_100is the wrapper's default feature).risc_proof_80sbis deliberately untouched — CI never runs the security_80 full test and regenerating it is blocked separately (see zkos-wrapper commit e4bc0c0).Why ❔
The automated wrapper-update flow breaks at "Generating fibonacci SNARK proof" with a clap argument-parsing error, since the pinned airbender's CLI no longer knows those flags.
Notes
expected=350timing hint for the section is likely optimistic now.🤖 Generated with Claude Code