feat(vk): support v33.1 private release generation - #32
Draft
itegulov wants to merge 6 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add v33.1 to the verification-key workflow, defaulting to
matter-labs/zksync-os-privatereleasev0.5.5and the wrapper workspace inmatter-labs/zksync-protocol-private. Require an explicit wrapper revision and contracts revision, and expose repository and wrapper-layout overrides to manual and reusable callers.The monorepo path matches prover v0.9.5-private: build 100-bit circuits and run
generate-vkwith both released application files, the real trusted setup, and--check-aux-params. Use the checksum-pinned 2^25 trusted setup required by the current SNARK domain, and raise the main-thread stack limit for synthesis. Older protocols retain the standalone wrapper CLI and 2^24 setup. Skip the removed FFLONK verifier when updating v33 contracts.Authenticate private release downloads and Cargo Git dependencies using the org read token, with
RELEASE_TOKENas a fallback. Always download the requested OS binary before generating a key, and upload the generated VK JSON and hash alongside the contracts patch.Why?
The existing workflow only supports protocols through v32.0 and unauthenticated public release downloads. v33.1 needs a separate proving key for its private OS release even though it can replay v33.0 blocks. The current prover uses a different wrapper CLI from the older standalone repository, and application binding must be enabled explicitly when generating its key.