feat: blob computation overhead for pubdata price#693
Merged
perekopskiy merged 3 commits intomainfrom Dec 4, 2025
Conversation
Test results148 tests 148 ✅ 9m 13s ⏱️ Results for commit 5a6f248. ♻️ This comment has been updated with latest results. |
perekopskiy
commented
Dec 2, 2025
RomanBrodetski
previously approved these changes
Dec 2, 2025
Collaborator
RomanBrodetski
left a comment
RomanBrodetski
left a comment
There was a problem hiding this comment.
looks good - but please consider my comment
AntonD3
reviewed
Dec 2, 2025
AntonD3
approved these changes
Dec 4, 2025
Contributor
AntonD3
left a comment
AntonD3
left a comment
There was a problem hiding this comment.
It may be better to introduce "filling factor" for future, but overall looks good
Contributor
Author
Sure, it's done in #700 |
Contributor
But will it apply for this computational overhead as well? |
Contributor
Author
|
Yes |
perekopskiy
deleted the
687-fee-model-take-into-account-blob-computation-overhead-when-calculating-pubdata_price
branch
RomanBrodetski
pushed a commit
that referenced
this pull request
Dec 11, 2025
🤖 I have created a release *beep* *boop* --- ## [0.12.1](v0.12.0...v0.12.1) (2025-12-11) ### Features * **batcher:** re-create batches using L1 watcher's data ([#672](#672)) ([11fefc4](11fefc4)) * blob computation overhead for pubdata price ([#693](#693)) ([bf69d65](bf69d65)) * **config:** Add config command ([#697](#697)) ([cd8a611](cd8a611)) * **config:** use EtherAmount for fee-related configs ([#676](#676)) ([28c27b1](28c27b1)) * Don't report Passthrough in batch_number metrics ([#683](#683)) ([7719fb3](7719fb3)) * JS tracer ([#569](#569)) ([c991043](c991043)) * remove failed transcations from block_output.tx_results ([#714](#714)) ([23b5323](23b5323)) * upgrade reth to 1.9.3/revm to 31.0.2 ([#709](#709)) ([521d473](521d473)) ### Bug Fixes * **l1-watcher:** handle L1 reverts during state recovery ([#692](#692)) ([d915174](d915174)) * **rpc:** move executed block check earlier in `zks_getL2ToL1LogProof` ([#704](#704)) ([117faa8](117faa8)) * state tracking for sequencer ([#715](#715)) ([01c3a6b](01c3a6b)) * upgrade issues in block context provider ([#666](#666)) ([e80cb85](e80cb85)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: zksync-era-bot <zksync-era-bot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For each blob created there is some calculation done that eventually has to be proven and the number of cycles is not negligible (in terms of cycles, one blob = tens of average txs).
We need to adjust pubdata price to take it into account.