feat!: EIP-4844 support #381
Open
+839
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoniolocascio
force-pushed
the
alocascio-4844-support
branch
from
b7575f5 to
c91c727
Compare
antoniolocascio
force-pushed
the
alocascio-4844-support
branch
2 times, most recently
from
a996945 to
cd979c2
Compare
6 tasks
0xVolosnikov
force-pushed
the
alocascio-4844-support
branch
from
cd979c2 to
7d222a5
Compare
6 tasks
antoniolocascio
force-pushed
the
alocascio-4844-support
branch
2 times, most recently
from
6252e19 to
b9e19ae
Compare
6 tasks
antoniolocascio
force-pushed
the
alocascio-4844-support
branch
from
b9e19ae to
ea157f1
Compare
antoniolocascio
force-pushed
the
alocascio-4844-support
branch
from
ea157f1 to
87dbfb5
Compare
antoniolocascio
force-pushed
the
alocascio-caches-sharing
branch
2 times, most recently
from
0476075 to
1577701
Compare
0xVolosnikov
force-pushed
the
alocascio-caches-sharing
branch
2 times, most recently
from
104059b to
7df9c67
Compare
Contributor
|
Should we merge it before the corresponding implementation in "V2"? |
0xVolosnikov
force-pushed
the
alocascio-4844-support
branch
from
87dbfb5 to
ca3b05b
Compare
Note: for now we just pass blob_fee instead of excess blob gas. This means that tests related to excess blob gas aren't supported.
0xVolosnikov
force-pushed
the
alocascio-4844-support
branch
from
ca3b05b to
e2afe08
Compare
0xVolosnikov
reviewed
Jan 9, 2026
0xVolosnikov
reviewed
Jan 9, 2026
| )); | ||
| } | ||
|
|
||
| system.set_tx_context(TxLevelMetadata { |
Contributor
There was a problem hiding this comment.
nit: I don't really like that we do it in validate_and_compute_fee_for_transaction function - it's easy to forget/be confused about when and where we do different steps of the tx initialization. I see why it's here, maybe we will restructure it in the future
Contributor
Author
There was a problem hiding this comment.
Had to move it to avoid a copy of the blobs I think
0xVolosnikov
reviewed
Jan 9, 2026
basic_bootloader/src/bootloader/transaction_flow/zk/validation_impl.rs
Outdated
Show resolved
Hide resolved
0xVolosnikov
reviewed
Jan 9, 2026
0xVolosnikov
reviewed
Jan 9, 2026
0xVolosnikov
approved these changes
Jan 9, 2026
antoniolocascio
force-pushed
the
alocascio-4844-support
branch
from
c4341b5 to
f184cfe
Compare
Contributor
Benchmark report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What ❔
This PR adds (limited) EIP-4844 support. This includes:
This PR doesn't include excess-gas related computation/checks, as for now blob_fee is passed as metadata.
EIP-4844 is disabled for production and is only used for eth-runner, as we need to be fully EVM-equivalent to minimize divergences.
Why ❔
Is this a breaking change?
Checklist