Skip to content

Comments

test: improvements to eth-runner#382

Merged
0xVolosnikov merged 12 commits intodevfrom
new-eth-runner
Jan 12, 2026
Merged

test: improvements to eth-runner#382
0xVolosnikov merged 12 commits intodevfrom
new-eth-runner

Conversation

@antoniolocascio
Copy link
Contributor

What ❔

This PR includes several improvements to the eth-runner testing tool:

  • Removes special-case checks for coinbase address balance
  • Skips blocks with calls to unsupported precompiles
  • Support for webhooks for reporting errors
  • Support for proving, including with GPU

Why ❔

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

@0xVolosnikov 0xVolosnikov force-pushed the alocascio-4844-support branch from cd979c2 to 7d222a5 Compare November 10, 2025 18:30
@antoniolocascio antoniolocascio force-pushed the alocascio-4844-support branch 2 times, most recently from 6252e19 to b9e19ae Compare November 17, 2025 10:15
@0xVolosnikov 0xVolosnikov force-pushed the alocascio-4844-support branch 2 times, most recently from ca3b05b to e2afe08 Compare January 9, 2026 06:21
Base automatically changed from alocascio-4844-support to dev January 9, 2026 11:13
Copy link
Contributor

@0xVolosnikov 0xVolosnikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't review it in detail, but I looked through it and tested it locally

@github-actions
Copy link
Contributor

Benchmark report

Benchmark Symbol Base Eff Head Eff (%) Base Raw Head Raw (%) Base Blake Head Blake (%) Base Bigint Head Bigint (%)
block_19299001 process_block 310,281,429 310,281,429 (+0.00%) 267,616,189 267,616,189 (+0.00%) 410,620 410,620 (+0.00%) 9,023,830 9,023,830 (+0.00%)
block_22244135 process_block 191,270,546 191,270,546 (+0.00%) 164,354,914 164,354,914 (+0.00%) 172,030 172,030 (+0.00%) 6,040,788 6,040,788 (+0.00%)
precompiles bn254_ecadd 53,195 53,195 (+0.00%) 47,743 47,743 (+0.00%) 0 0 (+0.00%) 1,363 1,363 (+0.00%)
precompiles bn254_ecmul 732,162 732,162 (+0.00%) 567,974 567,974 (+0.00%) 0 0 (+0.00%) 41,047 41,047 (+0.00%)
precompiles bn254_pairing 72,742,932 72,742,932 (+0.00%) 58,214,788 58,214,788 (+0.00%) 0 0 (+0.00%) 3,632,036 3,632,036 (+0.00%)
precompiles ecrecover 480,063 478,321 (-0.36%) 311,279 310,013 (-0.41%) 0 0 (+0.00%) 42,196 42,077 (-0.28%)
precompiles id 925 925 (+0.00%) 925 925 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles keccak 137,578 137,578 (+0.00%) 137,578 137,578 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles modexp 32,134,726 32,134,726 (+0.00%) 21,476,906 21,476,906 (+0.00%) 0 0 (+0.00%) 2,664,455 2,664,455 (+0.00%)
precompiles p256_verify 749,478 749,478 (+0.00%) 470,786 470,786 (+0.00%) 0 0 (+0.00%) 69,673 69,673 (+0.00%)
precompiles point_evaluation 51,158,395 51,158,395 (+0.00%) 39,535,767 39,535,767 (+0.00%) 0 0 (+0.00%) 2,905,657 2,905,657 (+0.00%)
precompiles process_block 148,253,090 148,248,860 (-0.00%) 118,772,702 118,771,464 (-0.00%) 5,050 5,060 (+0.20%) 7,349,897 7,349,109 (-0.01%)
precompiles process_transaction 73,884,179 73,884,890 (+0.00%) 59,181,899 59,189,166 (+0.01%) 160 160 (+0.00%) 3,674,930 3,673,291 (-0.04%)
precompiles ripemd 8,028 8,028 (+0.00%) 8,028 8,028 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles run_tx_loop 147,696,160 147,690,968 (-0.00%) 118,293,692 118,303,628 (+0.01%) 180 180 (+0.00%) 7,349,897 7,346,115 (-0.05%)
precompiles sha256 13,167 13,167 (+0.00%) 13,167 13,167 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles system_init 43,890 43,890 (+0.00%) 43,890 43,890 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles verify_and_apply_batch 134,584 134,662 (+0.06%) 99,704 99,782 (+0.08%) 2,180 2,180 (+0.00%) 0 0 (+0.00%)

@0xVolosnikov 0xVolosnikov merged commit 066ef44 into dev Jan 12, 2026
15 checks passed
@0xVolosnikov 0xVolosnikov deleted the new-eth-runner branch January 12, 2026 10:38
RomanHiden pushed a commit to RomanHiden/zksync-os that referenced this pull request Jan 19, 2026
## What ❔
This PR includes several improvements to the eth-runner testing tool:
* Removes special-case checks for coinbase address balance
* Skips blocks with calls to unsupported precompiles
* Support for webhooks for reporting errors
* Support for proving, including with GPU

<!-- What are the changes this PR brings about? -->
<!-- Example: This PR adds a PR template to the repo. -->
<!-- (For bigger PRs adding more context is appreciated) -->

## Why ❔

<!-- Why are these changes done? What goal do they contribute to? What
are the principles behind them? -->
<!-- The `Why` has to be clear to non-Matter Labs entities running their
own ZK Chain -->
<!-- Example: PR templates ensure PR reviewers, observers, and future
iterators are in context about the evolution of repos. -->

## Is this a breaking change?
- [ ] Yes
- [ ] No

## Checklist

<!-- Check your PR fulfills the following items. -->
<!-- For draft PRs check the boxes as you complete them. -->

- [ ] PR title corresponds to the body of PR (we generate changelog
entries from PRs).
- [ ] Tests for the changes have been added / updated.
- [ ] Documentation comments have been added / updated.
- [ ] Code has been formatted.

---------

Co-authored-by: Vladislav Volosnikov <Volosnikov.apmath@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants