Skip to content

Comments

feat: make code size limit configurable#462

Closed
dimazhornyk wants to merge 29 commits intodevfrom
configurable-code-size-limit-dev
Closed

feat: make code size limit configurable#462
dimazhornyk wants to merge 29 commits intodevfrom
configurable-code-size-limit-dev

Conversation

@dimazhornyk
Copy link

What ❔

Why ❔

Is this a breaking change?

  • Yes
  • No

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted.

@dimazhornyk dimazhornyk changed the title Configurable code size limit dev feat: make code size limit configurable Dec 18, 2025
@0xVolosnikov
Copy link
Contributor

0xVolosnikov commented Dec 19, 2025

Generally LGTM. I agree with @antoniolocascio that it's not extremely nice that we keep adding more EE-specific stuff to the block context - as an option, we can add separate chain- and vm-specific metadata structs in future.

For now, we should decide if we want to commit code size on L1 (I think we do) and implement it

Legacy EVM state tests can be ignored

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

Benchmark report

Benchmark Symbol Base Eff Head Eff (%) Base Raw Head Raw (%) Base Blake Head Blake (%) Base Bigint Head Bigint (%)
block_19299001 process_block 310,145,978 310,082,708 (-0.02%) 267,480,898 267,417,628 (-0.02%) 410,610 410,610 (+0.00%) 9,023,830 9,023,830 (+0.00%)
block_22244135 process_block 190,536,399 190,520,379 (-0.01%) 163,620,927 163,604,907 (-0.01%) 172,020 172,020 (+0.00%) 6,040,788 6,040,788 (+0.00%)
precompiles bn254_ecadd 53,195 53,195 (+0.00%) 47,743 47,743 (+0.00%) 0 0 (+0.00%) 1,363 1,363 (+0.00%)
precompiles bn254_ecmul 732,162 732,162 (+0.00%) 567,974 567,974 (+0.00%) 0 0 (+0.00%) 41,047 41,047 (+0.00%)
precompiles bn254_pairing 72,742,932 72,742,932 (+0.00%) 58,214,788 58,214,788 (+0.00%) 0 0 (+0.00%) 3,632,036 3,632,036 (+0.00%)
precompiles ecrecover 478,271 478,740 (+0.10%) 309,907 310,220 (+0.10%) 0 0 (+0.00%) 42,091 42,130 (+0.09%)
precompiles id 925 925 (+0.00%) 925 925 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles keccak 137,578 137,578 (+0.00%) 137,578 137,578 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles modexp 32,134,685 32,134,685 (+0.00%) 21,476,865 21,476,865 (+0.00%) 0 0 (+0.00%) 2,664,455 2,664,455 (+0.00%)
precompiles p256_verify 749,478 749,478 (+0.00%) 470,786 470,786 (+0.00%) 0 0 (+0.00%) 69,673 69,673 (+0.00%)
precompiles point_evaluation 51,158,395 51,158,395 (+0.00%) 39,535,767 39,535,767 (+0.00%) 0 0 (+0.00%) 2,905,657 2,905,657 (+0.00%)
precompiles process_block 148,246,929 148,233,969 (-0.01%) 118,778,149 118,756,045 (-0.02%) 5,070 5,050 (-0.39%) 7,346,915 7,349,281 (+0.03%)
precompiles process_transaction 73,889,634 73,882,691 (-0.01%) 59,192,282 59,180,983 (-0.02%) 160 160 (+0.00%) 3,673,698 3,674,787 (+0.03%)
precompiles ripemd 8,028 8,028 (+0.00%) 8,028 8,028 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles run_tx_loop 147,697,922 147,685,551 (-0.01%) 118,307,382 118,285,547 (-0.02%) 180 180 (+0.00%) 7,346,915 7,349,281 (+0.03%)
precompiles sha256 13,167 13,167 (+0.00%) 13,167 13,167 (+0.00%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles system_init 42,680 42,829 (+0.35%) 42,680 42,829 (+0.35%) 0 0 (+0.00%) 0 0 (+0.00%)
precompiles verify_and_apply_batch 132,241 127,271 (-3.76%) 97,521 92,871 (-4.77%) 2,170 2,150 (-0.92%) 0 0 (+0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants