fixed notification handler override #696
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for issues mauron85#627 and mauron85#682
|
Works very well for us!! Thanks @ynunez |
|
Is there any chance that this PR got merged? |
|
@jiro412j no it hasn't been merged. I forked the repo and merged it https://github.com/floms/cordova-plugin-background-geolocation I am kind of disappointed that this PR hasn't received positive or negative feedback |
|
This fix definitely solves the nasty bug, thx @ynunez!!! IMHO it should really be merged into the master branch. |
|
Is there any chance this PR got merged? The project seems stall :( |
|
I've created a fork of this project and will be maintaining it and looking for others to help maintain. |
CoooWeee
added a commit
to CoooWeee/cordova-plugin-background-geolocation
that referenced
this pull request
Jun 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issues #627 and #682 . The notification center override show only happened when in debugging mode; otherwise it interferes with the push notification mechanism. The code for the debugging is already there, so removing unnecessary duplicate code causing the issue.