-
Notifications
You must be signed in to change notification settings - Fork 40
[UI] Labelling the interface #206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RCheesley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, a really good start! I have made a few comments but also I'd request we use quotation marks (" and ") only when indicating actual speech. For all others, use a single quote (' ') instead.
I agree in principle with the recommendations to remove all of the many ways that we use in the UI to indicate the same actions, and instead bring some consistency. This will, of course, have an impact on the translations so we might need to alert the translation teams to this when we merge the PR. It'll be quite a lot of work for them, I think.
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
Co-authored-by: Ruth Cheesley <[email protected]>
bf692b3 to
a342591
Compare
|
Still outstanding comments here, plus conflicts to look at. Hopefully quick fixes though! |
RCheesley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deffo not a quick fix. Had to add labels for all the headings because they weren't being picked up by the build process.
This PR adds documentation for better interface labels.