Skip to content

Conversation

@andersonjeccel
Copy link
Contributor

This PR adds documentation for better interface labels.

Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, a really good start! I have made a few comments but also I'd request we use quotation marks (" and ") only when indicating actual speech. For all others, use a single quote (' ') instead.

I agree in principle with the recommendations to remove all of the many ways that we use in the UI to indicate the same actions, and instead bring some consistency. This will, of course, have an impact on the translations so we might need to alert the translation teams to this when we merge the PR. It'll be quite a lot of work for them, I think.

@RCheesley
Copy link
Member

Still outstanding comments here, plus conflicts to look at. Hopefully quick fixes though!

@RCheesley RCheesley added documentation Improvements or additions to documentation pending-feedback labels Oct 24, 2024
Copy link
Member

@RCheesley RCheesley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deffo not a quick fix. Had to add labels for all the headings because they weren't being picked up by the build process.

@RCheesley RCheesley merged commit ad76dcb into mautic:5.x Mar 4, 2025
1 of 3 checks passed
@andersonjeccel andersonjeccel deleted the docs-labelling branch March 4, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation pending-feedback

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants