Add fence and rally missions to raw server#2544
Merged
julianoes merged 2 commits intomavlink:mainfrom May 5, 2025
Merged
Conversation
Contributor
|
@julianoes @JonasVautherin just wanted to make a quick intro, as noted in the PR description, @tborglum is indeed a fellow team member at Elroy, we're working together to build out our MAVSDK integration. We'll both keep an eye on this PR in case something comes up. Thanks again for all your work on this project! |
JonasVautherin
approved these changes
Apr 17, 2025
Collaborator
|
Thanks, looks like I need to fixup CI! |
julianoes
approved these changes
Apr 18, 2025
Collaborator
julianoes
left a comment
julianoes
left a comment
There was a problem hiding this comment.
Including tests! Very nice, thank you!
- Added fence and rally item vectors to the raw server so they can be sent and received independently from the mission vector. - Added getter for mission items based on the mission type; if an unsupported mission type is used, an empty vector is returned. - Added mission type parameter to ResultAndItemsCallback so server callbacks can use the relevant item vector. - Updated raw server calls to mission transfer server calls to use the mission type of messages instead of being hard coded mission. - Added raw server logic to only reset mission completion if mission items are received for a mission type mission. - Added raw server logic to clear fence and rally missions if needed. - Updated raw server test helper function to create mission items relevant to the mission type they are for. - Updated raw server tests to be parameterized with supported mission types.
- Changed test fixture member variable access. - Removed a todo that was resolved.
julianoes
force-pushed
the
add-raw-server-mission-types
branch
from
655535b to
5996495
Compare
|
Contributor
Author
|
Thanks to you all for what you're doing with this project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working with @jonathanreeves to update the mission server to support more mission types.
In this branch, I have done the following: