CMake custom command fails in certain build configurations

[OwenCochell]

Hello,

When adding the project via FetchContent, or when including it as a subdirectory, an error occurs when building. Specifically, when building the generate_core_mavlink_xml_header target, an error occurs as CMake can't find cmake/generate_embedded_xml.cmake.

This can be reproduced by the following CMake file:

cmake_minimum_required(VERSION 4.2)

project(test)

add_subdirectory(MAVSDK)

In this case, we are adding a sub-directory that contains the MAVSDK source, but this could be done via FetchContent as well. Configuring will go ok, but if CMake is asked to build all targets then the error occurs.

This is because there is a custom CMake command that uses the CMAKE_SOURCE_DIR variable to locate the root of the project. The problem is, when including MAVSDK using the methods defined above, this variable instead points to the root of the project including MAVSDK. Because the parent project does not have this file, a build error occurs. We fix this by instead navigating to the root manually from the problematic CMake file.

Please let me know if there are any changes required, this is a small patch. Also, if it is not intended to include MAVSDK in this way, then this change might not be useful.

Thanks!

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[julianoes]

Thanks!