Skip to content

Conversation

@dakejahl
Copy link
Collaborator

Noticed warnings in the console

     8.434 Warning: Unknown 'function': "center" - Vehicle.ActuatorsConfig - (Actuators::parseJson:496)
     8.434 Warning: Unknown 'function': "center" - Vehicle.ActuatorsConfig - (Actuators::parseJson:496)
     8.434 Warning: Unknown 'function': "center" - Vehicle.ActuatorsConfig - (Actuators::parseJson:496)

The PWM_AUX_CENT${i} parameters came in with PX4 in PX4/PX4-Autopilot#25897.

What is odd is we get the warning in QGC, but the UI still works properly. Then what is the purpose of this code?

Copilot AI review requested due to automatic review settings January 24, 2026 20:11
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for the new PX4 actuator per-channel parameter function "center" (e.g. PWM_AUX_CENT${i}) so QGroundControl stops logging “Unknown 'function': center” warnings when parsing the actuator config JSON. Also introduces a new top-level build.sh helper script.

Changes:

  • Recognize "center" in Actuators::parseJson and map it to a new enum value.
  • Add ChannelConfig::Function::Center to the actuator output channel config enum.
  • Add a root-level build.sh script to configure/build/run QGC (Qt auto-detect + venv-installed CMake).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
src/Vehicle/Actuators/Actuators.cc Parses "center" function for per-channel parameters to avoid “unknown function” warnings.
src/Vehicle/Actuators/ActuatorOutputs.h Extends ChannelConfig::Function enum with Center.
build.sh Adds a new developer build script (currently appears unrelated to the PR’s stated actuator-focused scope).

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

Pre-commit Checks Failed

Status Count
Passed 11
Failed 49
Hook Results
check yaml...............................................................Passed
check json...............................................................Passed
pretty format json.......................................................Failed
check xml................................................................Passed
check for merge conflicts................................................Passed
check for added large files..............................................Passed
trim trailing whitespace.................................................Failed
fix end of files.........................................................Failed
mixed line ending........................................................Passed
TruffleHog...............................................................Passed
clang-format.............................................................Failed
clang-tidy...............................................................Failed
ruff (legacy alias)......................................................Failed
ruff format..............................................................Failed
pyright..................................................................Failed
shellcheck...............................................................Failed
cmake-format.............................................................Failed
cmake-lint...............................................................Failed
Lint GitHub Actions workflow files.......................................Failed
yamllint.................................................................Failed
markdownlint.............................................................Failed
vale.....................................................................Failed
typos....................................................................Failed
Lint QML files...........................................................Failed
Qt static analysis (clazy)...............................................Passed
Check for Q_ASSERT in production code....................................Passed
Check vehicle null safety................................................Failed
Files Modified by Hooks
 .github/workflows/pr-checks.yml                       |  1 -
 src/Utilities/Compression/CMakeLists.txt              |  2 --
 src/Utilities/Geo/geographiclib.patch                 |  8 ++++----
 src/Utilities/Geo/ogckml22.xsd                        | 10 +++++-----
 src/Vehicle/FactGroups/VehicleGPSAggregateFactGroup.h |  2 +-
 test/Utilities/FileSystem/QGCFileHelperTest.cc        |  1 -
 6 files changed, 10 insertions(+), 14 deletions(-)

How to Fix

./tools/pre-commit.sh
git add -u && git commit --amend --no-edit

Run ID: 21321287341

@github-actions
Copy link
Contributor

github-actions bot commented Jan 24, 2026

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Test Results

linux_gcc_64: 479 passed, 0 skipped

Total: 479 passed, 0 skipped

Code Coverage

Coverage: 100.0%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl-aarch64.AppImage 187.02 MB
QGroundControl-installer-AMD64-ARM64.exe 74.51 MB
QGroundControl-installer-AMD64.exe 162.40 MB
QGroundControl-installer-ARM64.exe 75.35 MB
QGroundControl-mac.apk 159.46 MB
QGroundControl-windows.apk 159.52 MB
QGroundControl-x86_64.AppImage 174.85 MB
QGroundControl.apk 312.27 MB
QGroundControl.dmg 311.44 MB

No baseline available for comparison

Updated: 2026-01-24 21:38:02 UTC • Triggered by: MacOS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants