-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
actuators: add center to Actuators::parseJson #13897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Adds support for the new PX4 actuator per-channel parameter function "center" (e.g. PWM_AUX_CENT${i}) so QGroundControl stops logging “Unknown 'function': center” warnings when parsing the actuator config JSON. Also introduces a new top-level build.sh helper script.
Changes:
- Recognize
"center"inActuators::parseJsonand map it to a new enum value. - Add
ChannelConfig::Function::Centerto the actuator output channel config enum. - Add a root-level
build.shscript to configure/build/run QGC (Qt auto-detect + venv-installed CMake).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/Vehicle/Actuators/Actuators.cc |
Parses "center" function for per-channel parameters to avoid “unknown function” warnings. |
src/Vehicle/Actuators/ActuatorOutputs.h |
Extends ChannelConfig::Function enum with Center. |
build.sh |
Adds a new developer build script (currently appears unrelated to the PR’s stated actuator-focused scope). |
Pre-commit Checks Failed
Hook ResultsFiles Modified by HooksHow to Fix./tools/pre-commit.sh
git add -u && git commit --amend --no-editRun ID: 21321287341 |
c8fc88f to
883598b
Compare
Build ResultsPlatform Status
All builds passed. Test Resultslinux_gcc_64: 479 passed, 0 skipped Total: 479 passed, 0 skipped Code CoverageCoverage: 100.0% No baseline available for comparison Artifact Sizes
No baseline available for comparisonUpdated: 2026-01-24 21:38:02 UTC • Triggered by: MacOS |
Noticed warnings in the console
The PWM_AUX_CENT${i} parameters came in with PX4 in PX4/PX4-Autopilot#25897.
What is odd is we get the warning in QGC, but the UI still works properly. Then what is the purpose of this code?