Skip to content

fix(AppSettings): fix group divider visuals - #14896

Open
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:fix/settings-page-dividers
Open

fix(AppSettings): fix group divider visuals#14896
rubenp02 wants to merge 1 commit into
mavlink:masterfrom
Ventor-Innovations:fix/settings-page-dividers

Conversation

@rubenp02

@rubenp02 rubenp02 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Description

Adds a visible divider line between settings groups. Hides dividers when there is no visible settings group on both sides to avoid duplicates.

New divider style is consistent with the existing divider between this settings page navigation list and the settings view.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)
  • CI/Build changes
  • Other

Testing

  • Tested locally
  • Added/updated unit tests
  • Tested with simulator (SITL)
  • Tested with hardware

Platforms Tested

  • Linux
  • Windows
  • macOS
  • Android
  • iOS

Checklist

  • I have read the Contribution Guidelines
  • I have read the Code of Conduct
  • My code follows the project's coding standards
  • I have added tests that prove my fix/feature works
  • New and existing unit tests pass locally

By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).

Copilot AI balanced review requested due to automatic review settings August 19, 2026 12:57

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Adds a visible divider line between settings groups. Hides dividers when
there is no visible settings group on both sides to avoid duplicates.
@rubenp02
rubenp02 force-pushed the fix/settings-page-dividers branch from 2be6d6b to bc9e5c7 Compare August 19, 2026 13:05
@rubenp02 rubenp02 changed the title fix(AppSettings): add settings group dividers fix(AppSettings): fix group divider visuals Aug 19, 2026
@rubenp02

Copy link
Copy Markdown
Contributor Author

I'd consider the duplicate divider fix a clear bugfix that should go in the upcoming release. Let me know if the divider visuals are more of a feature and not fit for the release. But IMO, the current lack of dividers looks pretty bad. Just makes the list look like it has uneven spacing before one realizes it's because there's different sections. But that's just my opinion, of course.

@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.26%. Comparing base (f29efd3) to head (bc9e5c7).
⚠️ Report is 297 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14896      +/-   ##
==========================================
+ Coverage   25.47%   34.26%   +8.79%     
==========================================
  Files         769      944     +175     
  Lines       65912    85200   +19288     
  Branches    30495    39315    +8820     
==========================================
+ Hits        16788    29193   +12405     
+ Misses      37285    36546     -739     
- Partials    11839    19461    +7622     
Flag Coverage Δ
unittests 34.26% <ø> (+8.79%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 657 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1ea010...bc9e5c7. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ Build results unavailable — artifact download from one or more platform workflows failed (likely artifact retention expiry or transient API error). The combined report cannot be generated for this run.

See the Build Results workflow run for details.

@DonLakeFlyer DonLakeFlyer added this to the Release V5.2 milestone Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants