fix(AppSettings): fix group divider visuals - #14896
Conversation
Adds a visible divider line between settings groups. Hides dividers when there is no visible settings group on both sides to avoid duplicates.
2be6d6b to
bc9e5c7
Compare
|
I'd consider the duplicate divider fix a clear bugfix that should go in the upcoming release. Let me know if the divider visuals are more of a feature and not fit for the release. But IMO, the current lack of dividers looks pretty bad. Just makes the list look like it has uneven spacing before one realizes it's because there's different sections. But that's just my opinion, of course. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #14896 +/- ##
==========================================
+ Coverage 25.47% 34.26% +8.79%
==========================================
Files 769 944 +175
Lines 65912 85200 +19288
Branches 30495 39315 +8820
==========================================
+ Hits 16788 29193 +12405
+ Misses 37285 36546 -739
- Partials 11839 19461 +7622
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
See the Build Results workflow run for details. |
Description
Adds a visible divider line between settings groups. Hides dividers when there is no visible settings group on both sides to avoid duplicates.
New divider style is consistent with the existing divider between this settings page navigation list and the settings view.
Type of Change
Testing
Platforms Tested
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).