feat(FactSystem): update Facts on unit changes - #15006
Conversation
FactMetaData now observes the corresponding UnitsSettings Fact and notifies existing Fact instances when it changes, refreshing cooked values, ranges, and units. Before, unit changes made during Initial Setup prompted users to restart QGroundControl, disrupting the first-run UX. Unit settings now take effect immediately and no longer require a restart.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15006 +/- ##
==========================================
+ Coverage 25.47% 34.59% +9.12%
==========================================
Files 769 945 +176
Lines 65912 85595 +19683
Branches 30495 39445 +8950
==========================================
+ Hits 16788 29609 +12821
+ Misses 37285 36326 -959
- Partials 11839 19660 +7821
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 654 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Build ResultsPlatform Status
All builds passed. Pre-commit
Pre-commit hooks: 2 passed, 75 failed, 7 skipped. Test Resultslinux-coverage-integration: 51 passed, 0 skipped Code CoverageCoverage: 70.6% No baseline available for comparison Artifact Sizes
Updated: 2026-08-31 16:27:27 UTC • Commit: 26c8be1 • Triggered by: Linux |
Description
FactMetaData now observes the corresponding UnitsSettings Fact and notifies existing Fact instances when it changes, refreshing cooked values, ranges, and units.
Before, unit changes made during Initial Setup prompted users to restart QGroundControl, disrupting the first-run UX. Unit settings now take effect immediately and no longer require a restart.
Type of Change
Testing
Platforms Tested
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the project's dual license (Apache 2.0 and GPL v3).