Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughSummary by CodeRabbit
WalkthroughAdds defensive panic recovery to the async job executor with a new Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
…y transition to "failed"
e46ab9e to
50e1b1e
Compare
Merge activity
|

Summary
Fixes async jobs that become stuck in "processing" state when JSON marshaling fails during job execution. Previously, marshal failures would cause the job to exit without updating its status, leaving it permanently in the processing state.
Changes
markFailedhelper function to consistently update job status to "failed" with appropriate error detailsType of change
Affected areas
How to test
Test async job execution with marshal failures to verify jobs transition to failed state:
Screenshots/Recordings
N/A
Breaking changes
Related issues
N/A
Security considerations
No security implications. This change improves system reliability by preventing jobs from being stuck in processing state.
Checklist
docs/contributing/README.mdand followed the guidelines