fix: added responses input history column and fixed chunk conversion #725
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThe changes extend the system to capture, store, and display responses input history alongside existing logging infrastructure. A new database column is added, logging middleware extracts and persists responses input data, response processing is updated to properly convert responses to streaming responses, and the UI is enhanced to display the captured input history. Changes
Sequence DiagramsequenceDiagram
participant Request as BifrostRequest
participant Logger as LoggerPlugin
participant Migrator as Database
participant UI as UI Display
Request->>Logger: PreHook: Capture input
Logger->>Logger: extractInputHistory()<br/>(returns ChatMessage + ResponsesMessage)
Logger->>Logger: InitialLogData: Store both<br/>InputHistory & ResponsesInputHistory
Logger->>Migrator: Create Log entry with<br/>ResponsesInputHistoryParsed
Note over Migrator: Column: responses_input_history<br/>(serialized JSON)
Migrator-->>UI: Fetch LogEntry
UI->>UI: Render responses_input_history<br/>using LogResponsesMessageView
UI-->>Request: Display captured<br/>input messages
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (10)
🧰 Additional context used🧬 Code graph analysis (7)framework/logstore/migrations.go (2)
transports/bifrost-http/integrations/utils.go (1)
plugins/logging/operations.go (1)
framework/logstore/tables.go (2)
plugins/logging/utils.go (4)
plugins/logging/main.go (3)
ui/app/logs/views/logDetailsSheet.tsx (2)
⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for storing and displaying Responses API input history in logs, enabling better tracking and debugging of Responses API requests.
Changes
responses_input_historycolumn to the logs database tableLogResponsesOutputViewtoLogResponsesMessageViewfor reuse with both input and outputChatResponseafter converting toResponsesStreamResponseType of change
Affected areas
How to test
Breaking changes
The database schema has been updated with a new column. Users should run the application to trigger the migration.
Security considerations
No new security implications. The implementation follows the same patterns as existing log storage.
Checklist
docs/contributing/README.mdand followed the guidelines