This repository was archived by the owner on Jul 27, 2025. It is now read-only.
Consolidate and simplify account pages#2462
Merged
Conversation
zachgoll
deleted the
zachgoll/maybe-914-simplify-account-page-routes-and-template
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick refactor in preparation for updating the account activity views and other forms.
We previously had a "show" page per-accountable type, which led to a confusing view hierarchy of:
show.html.erb->_template.html.erb->_chart.html.erb->chart.html.erb(turbo frame)This is all now simplified into the shared
accounts_controlleras:show.html.erb->UI::AccountPage(VC)Also adds a basic pattern for using ViewComponent for more complex views that either have a lot of view logic or need to be broadcast from background jobs. All "application components" live under the
UI::namespace, a useful pattern for avoiding the need to suffix every component with_component.rb