Skip to content

Midi feedback for motorized faders #1382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Off-IT wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −1
Open

Midi feedback for motorized faders #1382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cfe0ee8
sendFeedback
Off-IT Dec 21, 2022
9cce56b
Fix wrong midi channel for even pages
Off-IT Dec 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/midi/src/common/midiprotocol.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ bool QLCMIDIProtocol::feedbackToMidi(quint32 channel, uchar value,
{
// for OMNI mode, retrieve the original MIDI channel where data was sent
if (midiChannel == MAX_MIDI_CHANNELS)
midiChannel = channel >> 12;
midiChannel = (channel >> 12) & 0x000F;

// Remove the 4 MSB bits to retrieve the QLC+ channel to be processed
channel = channel & 0x0FFF;
Expand Down
5 changes: 5 additions & 0 deletions ui/src/virtualconsole/vcslider.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1271,6 +1271,11 @@ void VCSlider::setSliderValue(uchar value, bool scale, bool external)
if (m_slider->isSliderDown() == false && val != m_slider->value())
emit requestSliderUpdate(val);

/* Send Feedback for motorized faders */
if (external) {
sendFeedback(val);
}

switch (sliderMode())
{
case Level:
Expand Down