fixtureeditor: reject definitions without modes - #2096
Open
gmint wants to merge 3 commits into
Open
Conversation
gmint
marked this pull request as ready for review
August 18, 2026 19:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent the Fixture Editor from saving a fixture definition that has no modes.
Root cause
Since v4.14.4,
QLCFixtureDef::loadXML()correctly rejects definitions without modes to prevent the crash fixed by #1775. The Fixture Editor could still create and save exactly that invalid definition, leaving it impossible to reopen.Changes
This preserves the engine-side load guard while preventing the editor from producing files it cannot reload.
Fixes #2095.
Validation
git diff --checkThe local workspace does not include CMake or Qt development dependencies, so the project's
make checksuite could not be run there.