Repository navigation
Conversation
The flows nightly lost its whole network module ten runs running: test_auth.py ends by booting the app at a deep link, which leaves an instance that dies shortly after, and the first network scenario's restart_app() died in its own pre-restart drain (app_errors() fails with 'No Flutter isolate found') before the stop/relaunch could run. The drain now treats the gone-isolate state as an empty drain — an app with no isolate has no error-monitor window left to launder (the same trade recover_from_wedge documents) — and the restart clears the wedge marker, which describes the outgoing instance. Real app errors and other drain failures still fail the restart. Pinned live in test_harness_recovery.py (core suite): kill Chrome, then restart_app() must relaunch a drivable app.
Killing Chrome for real takes the VM service down with it on CI (connection refused) — a different dead state than the nightly's (service answers, no isolate) — and the first dispatch run's scenario poisoned the rest of the core session with it. Raise the synthetic gone error from app_errors instead (the same idiom the wedge legs use) and keep the real stop/relaunch leg of the pin.
Owner
Author
|
Closing as superseded: #3539 ("fmtk e2e: restart_app tolerates a dead isolate in its pre-restart drain (#3469)") landed the same fix while this PR was open, and issue #3469 is already closed by it. Main's version covers the same behavior this PR implemented — the pre-restart drain treats a gone-isolate app as an empty drain (nothing left to launder), the restart proceeds, real drain errors and other failures still raise, and the fabricated dead-drain scenario pins it without killing Chrome. The rebase onto current main conflicts in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The nightly flows suite has failed every run since Sep 10 with a constant
signature: the whole
test_network.pymodule dies in a "No Flutter isolatefound" cascade.
test_auth.pyends by booting the app at a deep link, whichleaves an instance that dies shortly after (documented in that scenario's
own comment); the first network scenario then calls
Harness.restart_app()— the designated recovery — and dies inside therestart's own pre-restart drain, because
app_errors()fails on thealready-dead app before the stop/relaunch can run. The failure then cascades
through the module (details and the 10-run evidence trail in the issue).
The fix: the pre-restart drain treats the gone-isolate state as an empty
drain — an app with no isolate has no error-monitor window left to launder —
and
restart_app()clears the wedge marker before relaunching (the markerdescribes the outgoing instance). Both are the same trade
FlutterRun.recover_from_wedgealready documents: the alternative is everysubsequent test failing on a dead debug connection (#3231). Real app errors
and every other drain failure still fail the restart, so the
anti-laundering guarantee is intact.
Adds a pin in the core suite's
test_harness_recovery.py: patchapp_errorsto raise the synthetic gone-isolate failure (the same idiomthe wedge legs use — killing Chrome for real on CI takes the VM service
down with it, a different dead state), then
restart_app()must relauncha drivable app with the marker cleared.
Closes #3469.
Validation
fmtk-e2e-flowson this branch (run 35440973393): thenetwork module passed for the first time since Sep 9 — the constant
10-night cascade is gone. The three remaining failures in that run are
the pre-existing intermittent class (admin
Handlelist-render probe onslow first boots; an SSO landing), separate from this fix.
fmtk-e2e-core(run 35440971339) caught the first version ofthe new pin killing Chrome for real (it poisoned the session); the
reworked pin fabricates the state synthetically and the re-dispatched
core run (35442089582) is green: 18 passed, including the new pin.
(envelope-less with the mark in stderr; envelope-not-ok with the mark in
the message), a non-gone fmtk failure (still raises), real app errors
(still raise — anti-laundering intact), and
at_pathbehavior(unchanged).
outside the graded set).