This repository was archived by the owner on Aug 17, 2025. It is now read-only.
Added swipeL + swipeR + arrowL + arrowR events to DailyCharts form#1034
Open
croisez wants to merge 5 commits intomcguirepr89:mainfrom
Open
Added swipeL + swipeR + arrowL + arrowR events to DailyCharts form#1034croisez wants to merge 5 commits intomcguirepr89:mainfrom
croisez wants to merge 5 commits intomcguirepr89:mainfrom
Conversation
|
I really like this! |
Author
|
Hi,
of course, you can.
My pleasure.
KR
Louis
Le sam. 16 mars 2024, 18:53, Nachtzuster ***@***.***> a
écrit :
… I really like this!
Would you mind if I include these patches in my own fork?
—
Reply to this email directly, view it on GitHub
<#1034 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANRFSI5SSSC2X3GVAZO3YLYYSBJ5AVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBSGA3DGMZVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
When you say you added swipe functionality to mobile, what "mobile" are you referring to? |
Author
|
android devices
Le mer. 19 juin 2024, 20:45, jmtuts ***@***.***> a écrit :
… When you say you added swipe functionality to mobile, what "mobile" are
you referring to?
—
Reply to this email directly, view it on GitHub
<#1034 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANRFSNNBJPXRKFPU3RFBTLZIHGWFAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGMYDOMBQGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
i did not test on apple devices
Le mer. 19 juin 2024, 23:29, Louis Croisez ***@***.***> a
écrit :
… android devices
Le mer. 19 juin 2024, 20:45, jmtuts ***@***.***> a écrit :
> When you say you added swipe functionality to mobile, what "mobile" are
> you referring to?
>
> —
> Reply to this email directly, view it on GitHub
> <#1034 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AANRFSNNBJPXRKFPU3RFBTLZIHGWFAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGMYDOMBQGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
Thank you, but I guess I should have been more specific. Android OK, but
what application are you using?
Regards,
…On Wed, Jun 19, 2024 at 2:29 PM croisez ***@***.***> wrote:
android devices
Le mer. 19 juin 2024, 20:45, jmtuts ***@***.***> a écrit :
> When you say you added swipe functionality to mobile, what "mobile" are
> you referring to?
>
> —
> Reply to this email directly, view it on GitHub
> <
#1034 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AANRFSNNBJPXRKFPU3RFBTLZIHGWFAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGMYDOMBQGE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#1034 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5PPZE5ZFB2RJ73VXHNWT43ZIHZ5PAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGQ3TOOJQGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Author
|
android chrome browser
Le jeu. 20 juin 2024, 00:48, jmtuts ***@***.***> a écrit :
… Thank you, but I guess I should have been more specific. Android OK, but
what application are you using?
Regards,
On Wed, Jun 19, 2024 at 2:29 PM croisez ***@***.***> wrote:
> android devices
>
> Le mer. 19 juin 2024, 20:45, jmtuts ***@***.***> a écrit :
>
> > When you say you added swipe functionality to mobile, what "mobile"
are
> > you referring to?
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
>
#1034 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AANRFSNNBJPXRKFPU3RFBTLZIHGWFAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGMYDOMBQGE>
>
> > .
> > You are receiving this because you authored the thread.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
#1034 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/A5PPZE5ZFB2RJ73VXHNWT43ZIHZ5PAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGQ3TOOJQGQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#1034 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AANRFSMLNTLI544CNAV6TMTZIIDDHAVCNFSM6AAAAAA5PPQKTKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGU2DAMZXHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found complicated to enter the date in the DailyCharts form.
I then propose to add a swiping left/right on mobile, and arrow left/right on desktop.
Cheers.