-
Notifications
You must be signed in to change notification settings - Fork 831
bootutil: Add manifest-based loader for Direct XIP #2511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tomchy
wants to merge
11
commits into
mcu-tools:main
Choose a base branch
from
tomchy:feature/mcuboot/NCSDK-NONE_Transaction_manifest_xip_upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
bootutil: Add manifest-based loader for Direct XIP #2511
tomchy
wants to merge
11
commits into
mcu-tools:main
from
tomchy:feature/mcuboot/NCSDK-NONE_Transaction_manifest_xip_upstream
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ebfcaf to
aaf2a5a
Compare
tomchy
commented
Oct 22, 2025
tomchy
commented
Oct 22, 2025
aaf2a5a to
d8e62ff
Compare
Rename boot_version_cmp(..) to boot_compare_version(..). Reason: most of the boot APIs use verb as the second part of the function name. Signed-off-by: Tomasz Chyrowicz <[email protected]>
The boot_check_header_erased(..) function may use a common function to check for a buffer value (bootutil_buffer_is_erased). Checking function should return bool intead of int. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Rename boot_is_header_valid(..) to boot_check_header_valid(..). The fap and hdr arguments are misleading - they should always point to the same slot. Change the function signature to use slot number instead. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Rename boot_image_check(..) to boot_check_image(..). Most of boot APIs use verb as the second part of the function name. The fap and hdr arguments are misleading - they should always point to the same slot. Change the function signature to use slot number instead. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add missing API docs for the following functions: - boot_get_loader_state() - boot_get_image_max_sizes() - image_max_size *boot_get_max_app_size() Restrict visibility of the app_size* APIs, based on the configuration. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Move functions, that operate on the flash area and does not require the bootloader state or bootloader status into a separate, dedicated file. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Move the boot_get_max_app_size(..) API into bootutil_misc.c as this file has the remaining functions, that operate on the size array (i.e. boot_fetch_slot_state_sizes(..)) and is independent from the update type, thus moving it will reduce the code duplication in the future. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Move functions from loader.c that are independent from the update type into a dedicated file. That way it will be easier to provide alternative loader type without massive code duplication. This file is intended to be used by loader-like files instead and should not be included in the bootutil/_priv.h headers. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add a possibility to attach a basic manifest with expected digests to an image. Alter the image verification logic, so only digests specified by the manifest are allowed on the device. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add a simple logic that allows to attach a manifest TLV to an image. Signed-off-by: Tomasz Chyrowicz <[email protected]>
Add a loader variant that is capable of booting images, based on a simple manifest. Signed-off-by: Tomasz Chyrowicz <[email protected]>
d8e62ff to
3688d72
Compare
JarmouniA
reviewed
Oct 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some documentation for this feature? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a loader variant that is capable of booting images, based on a simple manifest.
Based on: #2503