Skip to content
This repository was archived by the owner on Feb 26, 2018. It is now read-only.

fix missing headers with multiple values#127

Open
sepbehroozi wants to merge 1 commit into
mcxiaoke:masterfrom
sepbehroozi:fix_headers
Open

fix missing headers with multiple values#127
sepbehroozi wants to merge 1 commit into
mcxiaoke:masterfrom
sepbehroozi:fix_headers

Conversation

@sepbehroozi

Copy link
Copy Markdown

hey there
in some responses headers we have multiple Set-Cookie headers.
volley always consider first value of these type of headers :

Header h = new BasicHeader(header.getKey(), header.getValue().get(0));

My solution is that we shouldn't consider only first item of header.getValue(). we should merge all values in array with ;

for more info about this bug and example see this

bacy pushed a commit to bacy/volley that referenced this pull request Dec 17, 2015
@sepbehroozi

Copy link
Copy Markdown
Author

knock knock
no one's here :|

@michaem

michaem commented Mar 24, 2016

Copy link
Copy Markdown

Hi, man. Did you fix that?

@sepbehroozi

Copy link
Copy Markdown
Author

Hey there
Yes I've fixed that in a clone of this repository
Here is the address :https://github.com/3pehrbehroozi/android-volley

@michaem

michaem commented Mar 28, 2016

Copy link
Copy Markdown

Thx, man. I saw it)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants