Skip to content

Fix handling of null in Text::cleanText() #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Fix handling of null in Text::cleanText() #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DaveChild/TextStatistics/Text.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ public static function cleanText($strText)
{

// Check for boolean before processing as string
if (is_bool($strText)) {
if (is_bool($strText) || is_null($strText)) {
return '';
}

Expand Down
1 change: 1 addition & 0 deletions tests/TextStatisticsTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ public function tearDown(): void
-------------------- */
public function testCleaning()
{
$this->assertSame('', DaveChild\TextStatistics\Text::cleanText(null));
$this->assertSame('', DaveChild\TextStatistics\Text::cleanText(false));
$this->assertSame('There once was a little sausage named Baldrick. and he lived happily ever after.', DaveChild\TextStatistics\Text::cleanText('There once was a little sausage named Baldrick. . . . And he lived happily ever after.!! !??'));
}
Expand Down