At-rule pages: change css links to macros

[estelle]

No description provided.

[github-actions]

Preview URLs (13 pages)

• /en-US/docs/Web/CSS/Reference/At-rules/@container
• /en-US/docs/Web/CSS/Reference/At-rules/@font-face/font-display
• /en-US/docs/Web/CSS/Reference/At-rules/@font-face/font-family
• /en-US/docs/Web/CSS/Reference/At-rules/@function
• /en-US/docs/Web/CSS/Reference/At-rules/@import/layer_function
• /en-US/docs/Web/CSS/Reference/At-rules/@import
• /en-US/docs/Web/CSS/Reference/At-rules/@layer
• /en-US/docs/Web/CSS/Reference/At-rules/@media/-webkit-transform-2d
• /en-US/docs/Web/CSS/Reference/At-rules/@media/color-gamut
• /en-US/docs/Web/CSS/Reference/At-rules/@media/prefers-color-scheme
• /en-US/docs/Web/CSS/Reference/At-rules/@namespace
• /en-US/docs/Web/CSS/Reference/At-rules/@page
• /en-US/docs/Web/CSS/Reference/At-rules/@property

Flaws (408)

URL: /en-US/docs/Web/CSS/Reference/At-rules/@container
Title: @container
Flaw count: 97

• broken_links:
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#hash_mark is a redirect
  • Can't resolve /en-US/docs/Web/CSS/block-contents
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
  • and 69 more flaws omitted
• macros:
  • Macro produces link /en-US/docs/Web/CSS/container-name which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/ident which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/container-name which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/container which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/container-name which is a redirect
  • and 18 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@font-face/font-display
Title: font-display
Flaw count: 13

• broken_links:
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
• macros:
  • Macro produces link /en-US/docs/Web/CSS/@font-face which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@font-face/font-family which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@font-face/font-stretch which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@font-face/font-style which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@font-face/font-weight which is a redirect
  • and 4 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@font-face/font-family
Title: font-family
Flaw count: 20

• broken_links:
  • /en-US/docs/Web/CSS/string is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/custom-ident is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#plus is a redirect
• macros:
  • Macro produces link /en-US/docs/Web/CSS/@font-face which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/font-family which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/Value_processing which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/Inheritance which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/Value_processing which is a redirect
  • and 11 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@function
Title: @function
Flaw count: 52

• broken_links:
  • Can't resolve /en-US/docs/Web/CSS/function-token
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#hash_mark is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • and 28 more flaws omitted
• macros:
  • Macro produces link /en-US/docs/Web/CSS/dashed-function which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/dashed-ident which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/dashed-ident which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/type which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/type which is a redirect
  • and 14 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@import
Title: @import
Flaw count: 137

• broken_links:
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • /en-US/docs/Web/CSS/url is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/string is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • and 123 more flaws omitted
• macros:
  • Macro produces link /en-US/docs/Web/CSS/string which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/url_value which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@layer which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@supports which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@charset which is a redirect
  • and 4 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@import/layer_function
Title: layer()
Flaw count: 8

• broken_links:
  • /en-US/docs/Web/CSS/ident is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • /en-US/docs/Web/CSS/ident is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#asterisk is a redirect
• macros:
  • Macro produces link /en-US/docs/Web/CSS/@import which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@layer which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@import which is a redirect

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@layer
Title: @layer
Flaw count: 12

• broken_links:
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
  • Can't resolve /en-US/docs/Web/CSS/rule-list
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#hash_mark is a redirect
  • /en-US/docs/Web/CSS/ident is a redirect
  • and 4 more flaws omitted
• macros:
  • Macro produces link /en-US/docs/Web/CSS/@import which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@import which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/revert-layer which is a redirect

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@media/-webkit-transform-2d
Title: -webkit-transform-2d
Flaw count: 10

• macros:
  • Macro produces link /en-US/docs/Web/CSS/transform which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/transform which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/transform which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@supports which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@media/-webkit-transform-3d which is a redirect
  • and 5 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@media/color-gamut
Title: color-gamut
Flaw count: 1

• macros:
  • Macro produces link /en-US/docs/Web/CSS/@media which is a redirect

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@media/prefers-color-scheme
Title: prefers-color-scheme
Flaw count: 2

• macros:
  • Macro produces link /en-US/docs/Web/CSS/color-scheme which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/color-scheme which is a redirect

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@namespace
Title: @namespace
Flaw count: 9

• broken_links:
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • /en-US/docs/Web/CSS/string is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#single_bar is a redirect
  • /en-US/docs/Web/CSS/url is a redirect
  • and 2 more flaws omitted
• macros:
  • Macro produces link /en-US/docs/Web/CSS/@charset which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@import which is a redirect

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@page
Title: @page
Flaw count: 30

• broken_links:
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#question_mark is a redirect
  • Can't resolve /en-US/docs/Web/CSS/declaration-rule-list
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#hash_mark is a redirect
  • /en-US/docs/Web/CSS/CSS_values_and_units/Value_definition_syntax#brackets is a redirect
  • Can't resolve /en-US/docs/Web/CSS/ident-token
  • and 8 more flaws omitted
• macros:
  • Macro produces link /en-US/docs/Web/CSS/margin which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/margin-top which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/margin-right which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/margin-bottom which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/margin-left which is a redirect
  • and 12 more flaws omitted

---

URL: /en-US/docs/Web/CSS/Reference/At-rules/@property
Title: @property
Flaw count: 17

• broken_links:
  • Can't resolve /en-US/docs/Web/CSS/custom-property-name
  • Can't resolve /en-US/docs/Web/CSS/declaration-list
• macros:
  • Macro produces link /en-US/docs/Web/CSS/dashed-ident which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@property/syntax which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@property/inherits which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@property/initial-value which is a redirect
  • Macro produces link /en-US/docs/Web/CSS/@property/syntax which is a redirect
  • and 10 more flaws omitted

External URLs (1)

URL: /en-US/docs/Web/CSS/Reference/At-rules/@namespace
Title: @namespace

• https://html.spec.whatwg.org/multipage/syntax.html (1 time) (Note! This may be a new URL 👀)

[chrisdavidmills]

LGTM

[Josh-Cena]

@estelle @chrisdavidmills Was there a motivation for this change? I think most of the writers are indifferent about the two ways and we'd treat the change from one to another as unnecessary. In fact, at this particular moment, doing so introduces more flaws because the macro produces a redirect. For this particular case—and a lot others involving @layer—this change is actually a regression because the original link is not code-formatted but cssxref produces code formatting, and this xref macro, unlike others, does not allow disabling code formatting. I will have to revert some of these regressive changes.

[Josh-Cena]

Just caught another one: #41973 (comment). I suspect there are a lot of other cases like this one, where the eventual markup changed inadvertently, but my checker can only catch the cases where it introduced dubious content (spaces in code, self-link etc.) but not others (such as changing Reference/Values/position-area_value to Reference/Properties/position-area on pages that's not the position-area property itself, or inadvertent code formatting for link texts without spaces). I would suggest that all merged PRs be carefully reviewed again to make sure these regressions get corrected; and again, I highly, highly agree with #41922 (comment) that this is not a well-motivated change; if it establishes a writing convention, then it needs to be discussed first, even if not documented. I'm generally in favor of using macros but I don't think a PR that migrates links to macros is productive.

[bsmth]

My 2c: it may be better to revert this series of PRs rather than review each again to find and correct regressions as the benefits don't seem to justify the time cost at the moment.

[chrisdavidmills]

Q: Would the time be better spent fixing the macro, or is it going to be really complicated? I mean, surely you could query the page type and generate the URL string from there?

Would it be worth spending an hour evaluating the complexity of that before reverting all this stuff?

[bsmth]

I think @argl has 'fixing the macro' on his TODO list for a while, so he can weigh in about how long it will take or how complex it will be. Certainly my personal preference would be to revert instead of spend time on it while it's having reader impact on prod, but happy to hear what others think.

[chrisdavidmills]

I think I'm just gonna revert them for now. Once it is fixed, we can automate such updates if it is something we feel is worth spending the time on.