Skip to content

Conversation

@karimkkanji
Copy link
Contributor

This pull request does the following things:

  1. Adds a new entry to the domains list for training instances: https://chis-4-testing.health.go.ke
  2. Updates the Titles to now show "eCHIS" instead of CHIS
  3. Updates assets due to the assets not previously tracked.

@alexosugo alexosugo requested a review from eljhkrr September 20, 2024 09:50
@christinawere
Copy link

@alexosugo once done, will this be in playstore? I really dont want the CHPs to use the browser.

@karimkkanji
Copy link
Contributor Author

@alexosugo once done, will this be in playstore? I really dont want the CHPs to use the browser.

@christinawere finalising testing locally

<instance name="eCHIS Training 1">https://chis-training.health.go.ke</instance>
<instance name="eCHIS Training 2">https://chis-training-2.health.go.ke</instance>
<instance name="eCHIS Training 3">https://chis-training-3.health.go.ke</instance>
<instance name="eCHIS Testing">https://chis-4-testing.health.go.ke</instance>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious naming for this instance as there are no testing 1-3 instances. It seems the intention was to continue naming according to training instance sequence.

Suggested change
<instance name="eCHIS Testing">https://chis-4-testing.health.go.ke</instance>
<instance name="eCHIS Testing 4">https://chis-4-testing.health.go.ke</instance>

@eljhkrr
Copy link
Member

eljhkrr commented Sep 26, 2024

I've made an attempt to regenerate secrets using the keystore provided by Ian and the bundle signing key ended up being different so training cannot be updated. I'm attaching it here if anyone needs to review.
secrets-chis_kenya.tar.gz
We'll have to republish the training app.

@alexosugo
Copy link

@eljhkrr When was the training last updated on Play Store and do we know by whom? I assume that by removing and republishing the app afresh, the review time will be longer since it'll be treated as a new app.

@eljhkrr
Copy link
Member

eljhkrr commented Sep 26, 2024

Last update was in September 2023 probably by Ian who has since left MoH. We've tried getting credentials used then and they're not the same as used to publish to the playstore. It's a one-time thing, once we have automated builds setup, publishing updates will be a lot smoother.

@eljhkrr
Copy link
Member

eljhkrr commented Oct 4, 2024

We've published an update to the app and can merge after secrets have been setup

@mrjones-plip
Copy link
Collaborator

I can help add secrets to this repo. Is it correct that we just need these 4 added?

ANDROID_SECRETS_KEY_CHIS_KENYA
ANDROID_SECRETS_IV_CHIS_KENYA
ANDROID_KEY_PASSWORD_CHIS_KENYA
ANDROID_KEYSTORE_PASSWORD_CHIS_KENYA

The other two in 1pass don't need a secret as far as I can tell as their common knowledge. GH has an upper bounds of secrets so we want to use them sparingly.

@eljhkrr
Copy link
Member

eljhkrr commented Oct 8, 2024

Thanks @mrjones-plip, just the 4 will do

@mrjones-plip
Copy link
Collaborator

3 secrets created. I did not create ANDROID_KEY_PASSWORD_CHIS_KENYA . Please use ANDROID_SECRETS_KEY_CHIS_KENYA instead as it has the same value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants