Skip to content

Conversation

@SinghCod3r
Copy link
Contributor

This PR fixes a bug where uploaded forms were missing the required prefix (e.g., contact:) in their internalId.

  • The logic in upload-forms.js has been updated to check for and add the correct prefix based on the form type.
  • An existing unit test in upload-forms.spec.js has been updated to account for this new, correct behavior.

Resolves #537.

@SinghCod3r
Copy link
Contributor Author

@jkuester , i have resolved the issue. i also corrected the test file. As it was needed to be changed. i request you to review this earliest and merge this if no issue found.

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@SinghCod3r SinghCod3r force-pushed the fix/form-id-prefix-537 branch from 4a109d1 to a51ea20 Compare August 28, 2025 10:44
@SinghCod3r
Copy link
Contributor Author

@jkuester It looks like the E2E test is failing with a timeout. I tried re-running it, but it failed again. It doesn't seem related to my changes. Could you please take a look?

@jkuester jkuester self-requested a review August 28, 2025 21:31
@jkuester
Copy link
Contributor

👀 Seems like the problem with the e2e tests is unrelated to this PR/branch. I seem to be able to reproduce it locally running the main branch. Doing more investigation now....

@jkuester
Copy link
Contributor

Okay, tracked down the issue and raised #743. Will just need to merge in master once that PR is completed. 👍

@SinghCod3r
Copy link
Contributor Author

@jkuester , okay then i will wait for your review and comment.

@jkuester
Copy link
Contributor

Thanks! I have ~10 PRs in the queue waiting to be reviewed 😅 so I might not get to this until next week, but I have it on my list. 👍

@andrablaj andrablaj requested review from jkuester and removed request for jkuester November 4, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upload forms with correct format in the internalID property

2 participants