chore: add resolutions. Needed for CI #2555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess we should remove the tests in this repo then for the CI branch because they wouldn't work anymore, right? |
|
Yeah, they won't out of the box. Also, I see we have just one health check test, so won't hurt that much. CC @olivermrbl |
|
Cool, can you remove the tests as part of your PR? |
Remove just the tests or remove the workflow file? Because, even the installation of packages won't work. |
Not sure what tests you're referring to, but yes I mean the github workflow file |
|
Done :) |
shahednasser
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need the CI branch to contain resolutions, so that it will install the packages from the checked out code in the CI and not pull them from npm registry.