Fix Product List Pagination to Include First Page of Results #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AhmadBilalAmjad is attempting to deploy a commit to the medusajs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @AhmadBilalAmjad ! Thanks for the contribution and sorry for the very late reply. I believe this was fixed with the introduction of Will be closing this PR, feel free to re-open if the issue still exists |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a pagination issue in the getProductsList function. By updating the default pageParam from 1 to 0, we ensure the function starts pagination from the first page of results. Previously, starting at pageParam = 1 caused an offset that skipped the initial set of products. Now, pagination will begin correctly at the first record set, providing a complete list of products without omissions.
Changes: