New endpoint customize callback to provide settings dynamically #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some dynamicity to endpoints creation. While you can still provide endpoint properties statically (e.g., room to join, label to use as display, RTP forwarding recipients, etc.), you can now also provide a
customizecallback function, where you can provide these properties dynamically any time a new publisher contacts an endpoint. This can be useful to, e.g., send different publishers of the same endpoint to different rooms, or configure different RTP forwarders for each publisher, and things like that. The PR comes with a basic example (server-dynamic) that shows it being used to customize the label.