Test suite: Avatar.svelte #164
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0026fb2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sm17p
commented
Jul 2, 2025
| this.#props = props; | ||
| // Run effects before dom updates | ||
| // for provide handlers with some execution time | ||
| watch.pre( |
There was a problem hiding this comment.
Changed the $effect to watch.pre over here. It felt to me that onLoadingStatusChange should be running before the dom updates, as it might be contain other reactive updates.
There was a problem hiding this comment.
This sounds like a breaking change but I'm not really sure, need some advice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Comprehensive Avatar Component Tests
Overview
Adds complete test suite for Avatar component with unit, component, and browser integration tests. Review after #162 merges.
Avatar Builder Changes
props.srcto triggerthis.#loadingStatus = "loading"only on prop updatesonLoadingStatusChangecallback now fires inpreeffectt o enable callback execution before DOM updatesTest Coverage
Key Features Tested
Quality Assurance
✅ All tests pass locally
✅ Cross-browser compatibility verified