Memfault Firmware SDK 1.30.1 (Build 15397)

Author: Memfault Inc

CHANGELOG.md

@@ -6,6 +6,23 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to
 [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.30.1] - 2025-10-03
+
+This is a patch release, fixing one bug and applying a minor code quality
+improvement to the Python tooling files.
+
+### 🐛 Fixed
+
+- nRF-Connect SDK:
+
+  - Fixed an issue where panic logs generated from ISRs caused a double fault
+    for Nordic nRF91 users where `CONFIG_LOG_MODE_IMMEDIATE=n` and
+    `MEMFAULT_LOG_TIMESTAMPS_ENABLE` is 1.
+
+- General:
+
+  - Added Python type annotations to the files in the `tasks` directory.
+
 ## [1.30.0] - 2025-09-23
 
 This is a minor release. Highlights:

VERSION

@@ -1,3 +1,3 @@
-BUILD ID: 15332
-GIT COMMIT: a6e147605b
-VERSION: 1.30.0
+BUILD ID: 15397
+GIT COMMIT: 1aae918e39
+VERSION: 1.30.1

components/include/memfault/version.h

@@ -20,8 +20,8 @@ typedef struct {
 } sMfltSdkVersion;
 
 #define MEMFAULT_SDK_VERSION \
-  { .major = 1, .minor = 30, .patch = 0 }
-#define MEMFAULT_SDK_VERSION_STR "1.30.0"
+  { .major = 1, .minor = 30, .patch = 1 }
+#define MEMFAULT_SDK_VERSION_STR "1.30.1"
 
 #ifdef __cplusplus
 }

ports/zephyr/common/memfault_logging.c

@@ -104,14 +104,11 @@ typedef struct MfltLogProcessCtx {
 #endif
 
 static void prv_log_process(const struct log_backend *const backend, union log_msg_generic *msg) {
-  // This can be called in IMMEDIATE mode from an ISR, so in that case,
-  // immediately bail. We currently can't safely serialize to the Memfault
-  // buffer from ISR context
-#if CONFIG_LOG_MODE_IMMEDIATE
+  // This can be called in IMMEDIATE mode from an ISR or when flushing logs via LOG_PANIC, so
+  // immediately bail. We currently can't safely serialize to the Memfault buffer from ISR context
   if (memfault_arch_is_inside_isr()) {
     return;
   }
-#endif
 
   // Copied flagging from Zephry's ring buffer (rb) implementation.
   const uint32_t flags = IS_ENABLED(CONFIG_LOG_BACKEND_FORMAT_TIMESTAMP) ?
@@ -166,16 +163,14 @@ LOG_BACKEND_DEFINE(log_backend_mflt, log_backend_mflt_api, true);
 
 // Tie Memfault's log function to the Zephyr buffer sender. This is *the* connection to Memfault.
 static int prv_log_out(uint8_t *data, size_t length, void *ctx) {
-#if defined(CONFIG_LOG_MODE_IMMEDIATE)
-  // In synchronous mode, logging can occur from ISRs. The zephyr fault handlers are chatty so
-  // don't save info while in an ISR to avoid wrapping over the info we are collecting.
-  // This function may also be run from LOG_PANIC. We also want to skip saving data in this case
-  // because the context object uses local stack memory which may not be valid when run from
-  // LOG_PANIC
+  // In IMMEDIATE mode, logging can occur from ISRs. The zephyr fault handlers are chatty so don't
+  // save info while in an ISR to avoid wrapping over the info we are collecting. This function may
+  // also be run from LOG_PANIC. We also want to skip saving data in this case because we currently
+  // can't safely serialize to the Memfault buffer from ISR context and the context object uses
+  // local stack memory which may not be valid when run from LOG_PANIC
   if (memfault_arch_is_inside_isr()) {
     return (int)length;
   }
-#endif
 
   sMfltLogProcessCtx *mflt_ctx = (sMfltLogProcessCtx *)ctx;
   size_t save_length = length;

tasks/esp32.py

@@ -3,15 +3,21 @@
 # See LICENSE for details
 #
 
+from __future__ import annotations
+
 import os
 import re
 import shutil
 import sys
+from typing import TYPE_CHECKING
 
 from invoke import Collection, task
 
 from .gdb import gdb_build_cmd
 
+if TYPE_CHECKING:
+    from tasks.lib.invoke_utils import Context
+
 TASKS_DIR = os.path.dirname(__file__)
 MEMFAULT_SDK_ROOT = os.path.join(TASKS_DIR, "..")
 ESP32_PLATFORM_ROOT = os.path.join(MEMFAULT_SDK_ROOT, "examples", "esp32")
@@ -25,7 +31,7 @@
 OPENOCD_GDB_PORT_DEFAULT = 3333
 
 
-def _run_idf_script(ctx, *args, **kwargs):
+def _run_idf_script(ctx: "Context", *args: str, **kwargs: object) -> None:
     # allow selecting a specific python interpreter instead of the active one.
     # this is necessary in CI, because the mbed build task modifies the python
     # environment 😖, and idf.py runs a pkg_resources.require() which fails if
@@ -52,7 +58,7 @@ def _run_idf_script(ctx, *args, **kwargs):
 
 
 @task
-def run_xtensa_toolchain_check(ctx):
+def run_xtensa_toolchain_check(ctx: "Context") -> None:
     if sys.version_info.major < 3:
         # shutil which is only available for python3
         return
@@ -70,19 +76,19 @@ def run_xtensa_toolchain_check(ctx):
 
 
 @task(pre=[run_xtensa_toolchain_check])
-def esp32_app_build(ctx):
+def esp32_app_build(ctx: "Context") -> None:
     """Build the ESP32 test app"""
     _run_idf_script(ctx, "build")
 
 
 @task
-def esp32_app_clean(ctx):
+def esp32_app_clean(ctx: "Context") -> None:
     """Clean the ESP32 test app"""
     _run_idf_script(ctx, "fullclean")
 
 
 @task(pre=[run_xtensa_toolchain_check])
-def esp32s2_app_build(ctx):
+def esp32s2_app_build(ctx: "Context") -> None:
     """Build the ESP32-S2 test app"""
     # !NOTE! 'set-target' was added in ESP-IDF v4.1. If you are using an older
     # version of ESP-IDF, building for the ESP32-S2 + ESP32-S3 won't work.
@@ -91,32 +97,32 @@ def esp32s2_app_build(ctx):
 
 
 @task(pre=[run_xtensa_toolchain_check])
-def esp32s3_app_build(ctx):
+def esp32s3_app_build(ctx: "Context") -> None:
     """Build the ESP32-S3 test app"""
     _run_idf_script(ctx, "set-target esp32s3")
     _run_idf_script(ctx, "build")
 
 
 @task
-def esp32_app_flash(ctx):
+def esp32_app_flash(ctx: "Context") -> None:
     """Flash the ESP32 test app"""
     _run_idf_script(ctx, "flash")
 
 
 @task
-def esp32_console(ctx):
+def esp32_console(ctx: "Context") -> None:
     """Flash the ESP32 test app"""
     _run_idf_script(ctx, "monitor")
 
 
 @task
-def esp32_app_menuconfig(ctx):
+def esp32_app_menuconfig(ctx: "Context") -> None:
     """Run menuconfig for the ESP32 test app"""
     _run_idf_script(ctx, "menuconfig", pty=True)
 
 
 @task
-def esp32_openocd(ctx):
+def esp32_openocd(ctx: "Context") -> None:
     """Launch openocd"""
     if "ESP32_OPENOCD" not in os.environ:
         print("Set ESP32_OPENOCD environment variable to point to openocd-esp32 root directory!")
@@ -134,7 +140,7 @@ def esp32_openocd(ctx):
 
 
 @task
-def esp32_app_gdb(ctx, gdb=None, reset=False):
+def esp32_app_gdb(ctx: "Context", gdb: int | None = None, reset: bool = False) -> None:
     """Launches xtensa-gdb with app elf and connects to openocd gdb server"""
     if gdb is None:
         gdb = OPENOCD_GDB_PORT_DEFAULT
@@ -146,7 +152,9 @@ def esp32_app_gdb(ctx, gdb=None, reset=False):
 
 
 @task
-def esp32_decode_backtrace(ctx, backtrace_str, symbol_file, verbose=False):
+def esp32_decode_backtrace(
+    ctx: "Context", backtrace_str: str, symbol_file: str, verbose: bool = False
+) -> None:
     """Decode a backtrace emitted by ESP-IDF panic handling
 
     The backtrace_str should be passed as a string of separated address pairs

tasks/gdb.py

@@ -3,13 +3,15 @@
 # See LICENSE for details
 #
 
+from __future__ import annotations
+
 try:
     from shutil import which  # Python 3
 except ImportError:  # Python 2
     from distutils.spawn import find_executable as which
 
 
-def gdb_find(prefix=None):
+def gdb_find(prefix: str | None = None) -> str:
     if prefix is None:
         prefix = "arm-none-eabi-"
     base_name = "{}gdb".format(prefix)
@@ -21,7 +23,13 @@ def gdb_find(prefix=None):
     raise FileNotFoundError("Cannot find {}".format(" or ".join(ordered_names)))
 
 
-def gdb_build_cmd(extra_args, elf, gdb_port, reset=True, gdb_prefix=None):
+def gdb_build_cmd(
+    extra_args: str | None,
+    elf: str,
+    gdb_port: int,
+    reset: bool = True,
+    gdb_prefix: str | None = None,
+) -> str:
     base_cmd = '{gdb} --eval-command="target remote localhost:{port}"'.format(
         gdb=gdb_find(gdb_prefix), port=gdb_port
     )

tasks/macos_ftdi.py

@@ -3,17 +3,24 @@
 # See LICENSE for details
 #
 
+from __future__ import annotations
+
+from collections.abc import Generator
 from contextlib import contextmanager
 from os import uname
+from typing import TYPE_CHECKING
+
+if TYPE_CHECKING:
+    from tasks.lib.invoke_utils import Context
 
 APPLE_FTDI_DRIVER_BUNDLE_ID = "com.apple.driver.AppleUSBFTDI"
 
 
-def is_macos():
+def is_macos() -> bool:
     return uname()[0] == "Darwin"
 
 
-def _unload_apple_ftdi_driver_if_needed(ctx):
+def _unload_apple_ftdi_driver_if_needed(ctx: Context) -> bool | None:
     if not is_macos():
         return None
     result = ctx.run("kextstat -b {}".format(APPLE_FTDI_DRIVER_BUNDLE_ID), hide=True)
@@ -24,15 +31,15 @@ def _unload_apple_ftdi_driver_if_needed(ctx):
     return loaded
 
 
-def _load_apple_ftdi_driver_if_needed(ctx):
+def _load_apple_ftdi_driver_if_needed(ctx: Context) -> None:
     if not is_macos():
         return
     print("Re-loading Apple FTDI driver...")
     ctx.run("sudo kextload -b {}".format(APPLE_FTDI_DRIVER_BUNDLE_ID))
 
 
 @contextmanager
-def apple_ftdi_driver_disable(ctx):
+def apple_ftdi_driver_disable(ctx: Context) -> Generator[None, None, None]:
     was_ftdi_driver_loaded = _unload_apple_ftdi_driver_if_needed(ctx)
     try:
         yield

tasks/mbed.py

@@ -3,15 +3,21 @@
 # See LICENSE for details
 #
 
+from __future__ import annotations
+
 import os
 import shlex
 import shutil
 import sys
+from typing import TYPE_CHECKING
 
 from invoke import Collection, task
 
 from .print_chunk_watcher import PrintChunkWatcher
 
+if TYPE_CHECKING:
+    from tasks.lib.invoke_utils import Context
+
 TASKS_DIR = os.path.dirname(__file__)
 MEMFAULT_SDK_ROOT = os.path.dirname(TASKS_DIR)
 MBED_TARGET = "DISCO_F429ZI"
@@ -29,7 +35,7 @@
 
 
 @task
-def mbed_clean(ctx):
+def mbed_clean(ctx: Context) -> None:
     """Clean demo app that runs on Mbed OS 5"""
     print("Mbed CLI does not have a separate 'clean' action; approximating it...")
     if os.path.exists(MBED_DEMO_APP_BUILD_ROOT):
@@ -38,7 +44,7 @@ def mbed_clean(ctx):
 
 
 @task
-def mbed_update(ctx):
+def mbed_update(ctx: Context) -> None:
     """Update or install the library dependencies for the Mbed demo app"""
     cmd = "mbed update"
     with ctx.cd(MBED_DEMO_APP_ROOT):
@@ -74,7 +80,7 @@ def mbed_update(ctx):
 
 
 @task
-def _mbed_update_required(ctx):
+def _mbed_update_required(ctx: Context) -> None:
     """Most tasks require that the mbed_update task have been run at least once
     before to install mbed-os.  Do it now if it has not been done yet."""
     mbed_dir = os.path.join(MBED_DEMO_APP_ROOT, "mbed-os")
@@ -93,12 +99,12 @@ def _mbed_update_required(ctx):
     },
 )
 def mbed_build(
-    ctx,
-    profile=MBED_DEMO_APP_BUILD_PROFILE,
-    toolchain=MBED_TOOLCHAIN,
-    target=MBED_TARGET,
-    flash=False,
-):
+    ctx: Context,
+    profile: str = MBED_DEMO_APP_BUILD_PROFILE,
+    toolchain: str = MBED_TOOLCHAIN,
+    target: str = MBED_TARGET,
+    flash: bool = False,
+) -> None:
     """Build the demo app that runs on Mbed OS 5"""
     cmd = "mbed compile --profile {} --toolchain {} --target {}".format(
         shlex.quote(profile), shlex.quote(toolchain), shlex.quote(target)
@@ -124,7 +130,7 @@ def mbed_build(
 @task(
     pre=[_mbed_update_required], help={"target": "Mbed target name (def: {})".format(MBED_TARGET)}
 )
-def mbed_flash(ctx, target=MBED_TARGET):
+def mbed_flash(ctx: Context, target: str = MBED_TARGET) -> None:
     """Flash (and first build) the demo app that runs on Mbed OS 5"""
     print("Mbed CLI does not have a separate 'flash' action; approximating it...")
     mbed_build(ctx, flash=True, target=target)
@@ -138,7 +144,7 @@ def mbed_flash(ctx, target=MBED_TARGET):
         "target": "Mbed target name (def: {})".format(MBED_TARGET),
     },
 )
-def mbed_console(ctx, baudrate=MBED_BAUD_RATE, target=MBED_TARGET):
+def mbed_console(ctx: Context, baudrate: int = MBED_BAUD_RATE, target: str = MBED_TARGET) -> None:
     """Start an Mbed serial console to interact with the demo app"""
     cmd = "mbed sterm --baudrate {:d} --echo off --target {}".format(baudrate, shlex.quote(target))
     with ctx.cd(MBED_DEMO_APP_ROOT):