fix the OOB buffer access issue in src/text/draw.rs when switching to text view at the end of the file#40
Merged
merces merged 3 commits intomentebinaria:mainfrom Feb 19, 2026
Merged
Conversation
initial approach via .windows(siz) is too slow on huge files
at the end of file with size > area.height * area.width
Member
|
Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you open a file larger than
area.height * area.widthand go to the last page (G), then switch to text view (Enter), you should get a similar panic:In this PR I am fixing the issue.
NOTE: should be merged on top of #39.