Revert fix: make e2e scoping on-by-default so fork PRs benefit#7948
Revert fix: make e2e scoping on-by-default so fork PRs benefit#7948aloisklink wants to merge 1 commit into
fix: make e2e scoping on-by-default so fork PRs benefit#7948Conversation
…scope-skip-ignorable-files This reverts commit 71f9731 (Merge pull request mermaid-js#7709 from mermaid-js/chore/e2e-scope-skip-ignorable-files, 2026-05-05). The E2E scoping seems to be broken with Argos, and it's much less important now that we're batching image uploads by default since 1265ee1 (feat(e2e): batch Argos screenshots into folder-wise composite sheets, 2026-06-18). By reverting 71f9731, we can disable E2E scoping for our own internal PRs by setting `E2E_SCOPE_BY_DIAGRAM`, but this won't help with PRs from forks. See: 1265ee1
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📝 WalkthroughWalkthroughThe e2e.yml workflow's scoping kill-switch logic was changed from defaulting to enabled (disabled only when explicitly "false") to defaulting to disabled (enabled only when explicitly "true"), affecting both the detect-scope step condition and the job-level environment variable expression. ChangesE2E Scope Flag Default Behavior
Estimated code review effort: 2 (Simple) | ~5 minutes Related Issues: None found in the provided context. Related PRs: None found in the provided context. Suggested labels: ci, workflow Suggested reviewers: None found in the provided context. 🐰 A flag once loose, now held up tight, 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
fix: make e2e scoping on-by-default so fork PRs benefit
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7948 +/- ##
===========================================
+ Coverage 77.42% 77.52% +0.10%
===========================================
Files 564 564
Lines 74900 74906 +6
Branches 12659 14617 +1958
===========================================
+ Hits 57988 58068 +80
+ Misses 15915 15841 -74
Partials 997 997
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
📑 Summary
This reverts commit 71f9731/#7709, which will disable E2E scoping from PRs from forks.
The E2E scoping seems to be broken with Argos (causing it to be stuck with Waiting for status to be reported — Build is queued), and it's much less important now that we're batching image uploads by default since 1265ee1.
Without reverting 71f9731, we can disable E2E scoping for our own internal PRs by setting
E2E_SCOPE_BY_DIAGRAM, but this won't help with PRs from forks.See: 1265ee1
📏 Design Decisions
I'm sure we can probably modify how we're calling Argos to tell it when a build is queued when running a CI subset, but considering we're batching screenshots anyway, it's not too big of a deal to disable this code completely.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.This PR reverts the E2E scoping change that disabled forked-PR scoped runs.
detect-scopekill-switch behavior that treated scoping as disabled only whenE2E_SCOPE_BY_DIAGRAMwas explicitly"false".E2E_SCOPE_BY_DIAGRAMenv derivation so the scoped workflow is no longer enabled by default via the repo variable fallback.