Skip to content

Conversation

@lb90
Copy link
Contributor

@lb90 lb90 commented Nov 1, 2025

Fixes #2469

@lb90
Copy link
Contributor Author

lb90 commented Nov 1, 2025

Note: this is based on https://gitlab.freedesktop.org/gstreamer/meson-ports/libffi/-/blob/meson/src/meson.build?ref_type=heads but the licensing is unclear. Maybe we can ask @nirbheek?

@lb90 lb90 force-pushed the fix-issue-2469 branch 2 times, most recently from e4cd969 to e1b4255 Compare November 3, 2025 10:42
@lb90
Copy link
Contributor Author

lb90 commented Nov 3, 2025

Ci failures look unrelated to the PR:

  • Alpine (riscv64): libffi test failures
  • MacOS (arm64): libffi test failures
  • VisualStudio-clang-cl: libffi test timeout

@lb90 lb90 marked this pull request as ready for review November 3, 2025 10:59
@xclaesse
Copy link
Member

xclaesse commented Nov 3, 2025

I marked the fix in Meson for backport in 1.9.2. TBH, I'm not sure we want to maintain workarounds like that, I would just error('Windows aarch64 requires Meson >= 1.9.2'). On Windows it's trivial to pip install latest Meson, unlike Linux distro where it can take the age of the universe to update a package (I'm still building products on Ubuntu 20.04...).

@lb90
Copy link
Contributor Author

lb90 commented Nov 3, 2025

Yeah, makes sense! Thanks a lot for backporting

Should I add the error('Windows aarch64 requires Meson >= 1.9.2'), then? I don't know if it's worth upgrading the wrap version number just for that.

@xclaesse
Copy link
Member

xclaesse commented Nov 3, 2025

Should I add the error('Windows aarch64 requires Meson >= 1.9.2'), then? I don't know if it's worth upgrading the wrap version number just for that.

I think that's simple enough that it's worth it, to avoid others hitting the same issue. We already do that kind of version checks.

@lb90 lb90 changed the title libffi: Add custom logic to invoke armasm64 with Meson < 1.10 libffi: Require Meson >= 1.9.2 for MSVC/ARM64 toolchain Nov 3, 2025
@xclaesse xclaesse merged commit c250d18 into mesonbuild:master Nov 4, 2025
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

libffi fails to configure in MSVC cross-build (vs2019, build x64, host ARM64)

2 participants