Skip to content

Conversation

sanex3339
Copy link
Contributor

Adds healthcheck banner.

We check the health status on any route change by wouter or when the tab is focused.
Also when status is maintenance, the status is checked every 15 seconds via polling

When status is ok after page change (or when status is maintenance and polling is enabled), the banner should be hidden.

When status is changed from non-ok to ok - page is reloaded via wouter to refetch data.

How to verify:

  • locally run yarn docker:up
  • when everything is up - open any page
  • then kill the container
  • then navigate via UI to any page - you will see the banner
  • not sure how to test the maintenance status locally without adjusting code. You can return status: 'maintenance' from src/utils/query-metabase-instance-status.ts and check that the polling is enabled. When status switched from maintenance to other status, polling should be disabled

@sanex3339 sanex3339 added the enhancement New feature or request label Apr 30, 2025
@sanex3339 sanex3339 requested a review from heypoom April 30, 2025 19:45
@sanex3339 sanex3339 self-assigned this Apr 30, 2025
@sanex3339 sanex3339 force-pushed the shoppy-mb-instance-health-banner branch from c46d388 to 71ab762 Compare April 30, 2025 19:46
Copy link

Preview Deployment Ready!
🔗 View Preview Deployment

Copy link

Preview Deployment Ready!
🔗 View Preview Deployment

@sanex3339 sanex3339 removed the request for review from heypoom May 1, 2025 03:19
@sanex3339 sanex3339 force-pushed the shoppy-mb-instance-health-banner branch from 71ab762 to 84711bf Compare May 1, 2025 09:11
Copy link

github-actions bot commented May 1, 2025

Preview Deployment Ready!
🔗 View Preview Deployment

@sanex3339 sanex3339 force-pushed the shoppy-mb-instance-health-banner branch from 84711bf to 5e662f8 Compare May 1, 2025 09:20
Copy link

github-actions bot commented May 1, 2025

Preview Deployment Ready!
🔗 View Preview Deployment

@sanex3339 sanex3339 force-pushed the shoppy-mb-instance-health-banner branch from 5e662f8 to e594a6b Compare May 1, 2025 13:23
Copy link

github-actions bot commented May 1, 2025

Preview Deployment Ready!
🔗 View Preview Deployment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant