Fix[LB-1785]: Impersonaly recommend#3620
Open
Swaim-Sahay wants to merge 1 commit intometabrainz:masterfrom
Open
Fix[LB-1785]: Impersonaly recommend#3620Swaim-Sahay wants to merge 1 commit intometabrainz:masterfrom
Swaim-Sahay wants to merge 1 commit intometabrainz:masterfrom
Conversation
- Create recommendation.entity_recommendation table with SQL schema - Add foreign keys, indexes, primary keys, and custom types - Implement DB layer (listenbrainz/db/entity_recommendation.py) - Add API endpoints for adding, removing, and retrieving recommendations - Register entity_recommendation blueprint in webserver
Member
|
Hi, I think this is the type of new feature that you should consult maintainers about, to ensure you are heading in the right direction first before producing code. This is currently only a partial feature. How do you want to surface it on the website and what is the UX going to look like? |
Member
|
I will also add, if you are looking for something to work on, please look at your older unfinished PRs rather than opening whole new ones. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds "Entity Recommendations" allowing users to recommend MusicBrainz entities (artists, releases, release groups, recordings) to each other via API. Recommendations are ranked by an auto computed specificity score and rate limited to 10/day.
Ticket: LB-1785
Problem
Users had no way to create personal entity to entity recommendations within ListenBrainz.
Solution
Added a new recommendation.entity_recommendation table and three API endpoints for adding, removing, and retrieving recommendations, with validation, auth, upsert support, and pagination.
Changes Made
AI Usage