LB-1956 : Music services settings UI improvements#3641
Open
Adam-Etyang wants to merge 7 commits intometabrainz:masterfrom
Open
LB-1956 : Music services settings UI improvements#3641Adam-Etyang wants to merge 7 commits intometabrainz:masterfrom
Adam-Etyang wants to merge 7 commits intometabrainz:masterfrom
Conversation
Adam-Etyang
changed the title
anshg1214
requested changes
Mar 25, 2026
Member
anshg1214
left a comment
anshg1214
left a comment
There was a problem hiding this comment.
I really love the new look.
For Youtube and Internet Archive, we don't have any configurations, so it does not make sense to show it as "Not Available"
Comment on lines
+503
to
+528
| <div | ||
| className="card-header" | ||
| role="button" | ||
| tabIndex={0} | ||
| onClick={() => togglePanel("spotify")} | ||
| onKeyDown={(e) => e.key === "Enter" && togglePanel("spotify")} | ||
| style={{ cursor: "pointer" }} | ||
| > | ||
| <span className="service-logo"> | ||
| <FontAwesomeIcon | ||
| icon={faSpotify} | ||
| className="service-icon" | ||
| color="#1DB954" | ||
| /> | ||
| </span> | ||
| <h3 className="card-title">Spotify</h3> | ||
| <div className="status-indicator"> | ||
| <div | ||
| className={`status-dot ${ | ||
| isConnected("spotify") ? "connected" : "disconnected" | ||
| }`} | ||
| /> | ||
| <span> | ||
| {isConnected("spotify") ? "Connected" : "Not Connected"} | ||
| </span> | ||
| </div> |
Member
There was a problem hiding this comment.
Since we're re-using this code in multiple places, can we move this to a shared component?
Author
The cards are now a shared component |
Member
|
@Adam-Etyang The tests are failing. Try running them locally to find the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Jira Ticket - LB-1956
Some users found the UI for the connecting services quite confusing where there were ways of figuring out what was or not connected or any icons or logos of the music service providers.
🔰 Mention the JIRA ticket (LB-XXX) if there is a relevant one
🔰 First PR? Have a look at this beginner's guide
Solution
The change is purely UI improvements of the aforementioned page where I've added icons/logos
for each music provier and made the vertical tabs toggle making it easier for users to navigate the page. I've also added status indicators to know what service is connected or not.
[ x ] I have run the code and manually tested the changes
[ x ] I used AI tools for coding
[ x ] I understand all the changes made in this PR
I used claude to help me understand how the files are arranged and to navigate the project directory and with the CSS styling.