LB-1964: Fix youtube player cross tab sync issue#3661
Open
meekhumor wants to merge 1 commit intometabrainz:masterfrom
Open
LB-1964: Fix youtube player cross tab sync issue#3661meekhumor wants to merge 1 commit intometabrainz:masterfrom
meekhumor wants to merge 1 commit intometabrainz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Ticket: LB-1964
When a user starts playback in a new tab,
stopOtherBrainzPlayers()triggers a localstorage event that callspauseCurrentPlayback()withdataSource.stop()on the previous tab.Issue arises due to the
stop()method in YoutubePlayer.tsxAlso I found this same issue with spotify player as well, soundcloud appears to sync correctly. I haven't tested other music services.
Solution
After going through this, fix was simply replacing
stopVideo()withpauseVideo()in thestop()method.Also removed the
cueVideoById("")call since we no longer need to hard reset the player instead the video should stay loaded for potential resume.AI usage
Action
No further actions needed beyond testing.