Fix: Contain scroll behavior in Art Creator settings panel (LB-1953)#3670
Open
Gopal7387 wants to merge 1 commit intometabrainz:masterfrom
Open
Fix: Contain scroll behavior in Art Creator settings panel (LB-1953)#3670Gopal7387 wants to merge 1 commit intometabrainz:masterfrom
Gopal7387 wants to merge 1 commit intometabrainz:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent scroll behavior in the Art Creator right settings panel where scrolling inside the panel would bleed into the main page scroll. LB-1953
Root Cause
Two things caused a problem with scrolling.
.settings-navbardid not have a height set.It used
height: max-contentfrom.sidebarwhich meant it did not have a boundary for scrolling.As a result, when
overscroll-behaviorwas triggered, there was nothing to hold it; scrolling events moved to the parent page easily.This happened because the height was not defined properly, and the
.settings-relied on.sidebar`, for its height, which caused issues with scrolling.Fix
Two properties added to
.settings-navbarinstats-art-creator.scss:1.
height: calc(100vh - 72px)gives the panel a fixed height matching the available viewport minus the navbar (72px), creating a real scroll container2.
overscroll-behavior: containprevents scroll chaining once the panel hits its scroll limitFiles Changed
frontend/css/sass/stats-art-creator.scss: 2 lines addedTesting Done
AI Usage
If you did use AI:
[ ] I used AI tools for communication
[ ] I used AI tools for coding
[ ] I understand all the changes made in this PR
Hence i have not used any LLM as the issue is direct and minimal