Skip to content

Conversation

@peppi-lotta
Copy link
Member

@peppi-lotta peppi-lotta commented Apr 24, 2025

What this PR does / why we need it: Release notes are not being generated in a file when log is used. We need to use fmt instead but forbidigo complains about using fmt so I added an ignore to the .golangci.yaml.

@metal3-io-bot metal3-io-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 24, 2025
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes-generator-and-comply-with-forbidigo branch from 1dd30a4 to d2b9186 Compare April 24, 2025 11:42
@metal3-io-bot metal3-io-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 24, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes-generator-and-comply-with-forbidigo branch from d2b9186 to b126258 Compare April 24, 2025 11:45
@metal3-io-bot metal3-io-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2025
Copy link
Member

@smoshiur1237 smoshiur1237 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes-generator-and-comply-with-forbidigo branch from b126258 to e44552e Compare April 25, 2025 07:22
@metal3-io-bot metal3-io-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 25, 2025
@peppi-lotta peppi-lotta force-pushed the peppi-lotta/fix-release-notes-generator-and-comply-with-forbidigo branch from e44552e to e64eedf Compare April 29, 2025 06:56
Copy link
Member

@tuminoid tuminoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tuminoid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2025
@adilGhaffarDev
Copy link
Member

/lgtm
@peppi-lotta do we need the same fix in capm3 and BMO too? If yes, please open PRs there too.

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 29, 2025
@tuminoid
Copy link
Member

/lgtm @peppi-lotta do we need the same fix in capm3 and BMO too? If yes, please open PRs there too.

That depends if the linter issues about forbidigo was merged in those repos and/or if linter is even configured to validate the notes.go.

We also might want to actually finalize metal3-io/project-infra#944 to not have fix these in each repo.

@adilGhaffarDev
Copy link
Member

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
Changes are only in the release note generation scripts, and these tests don't test that.

@metal3-io-bot
Copy link
Contributor

@adilGhaffarDev: Overrode contexts on behalf of adilGhaffarDev: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main
Changes are only in the release note generation scripts, and these tests don't test that.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot merged commit 344c1b1 into metal3-io:main Apr 29, 2025
14 checks passed
@metal3-io-bot metal3-io-bot deleted the peppi-lotta/fix-release-notes-generator-and-comply-with-forbidigo branch April 29, 2025 12:39
@metal3-io-bot metal3-io-bot added this to the IPAM - v1.10 milestone Apr 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants