-
Notifications
You must be signed in to change notification settings - Fork 42
🌱 Fix notes.go so that it still complies with forbidigo #1008
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fix notes.go so that it still complies with forbidigo #1008
Conversation
Sunnatillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
1dd30a4 to
d2b9186
Compare
d2b9186 to
b126258
Compare
smoshiur1237
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
b126258 to
e44552e
Compare
Signed-off-by: peppi-lotta <[email protected]>
e44552e to
e64eedf
Compare
tuminoid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tuminoid The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
That depends if the linter issues about forbidigo was merged in those repos and/or if linter is even configured to validate the notes.go. We also might want to actually finalize metal3-io/project-infra#944 to not have fix these in each repo. |
|
/override metal3-centos-e2e-integration-test-main metal3-ubuntu-e2e-integration-test-main |
|
@adilGhaffarDev: Overrode contexts on behalf of adilGhaffarDev: metal3-centos-e2e-integration-test-main, metal3-ubuntu-e2e-integration-test-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it: Release notes are not being generated in a file when
logis used. We need to usefmtinstead but forbidigo complains about using fmt so I added an ignore to the.golangci.yaml.