Make the JavaScript parser compliant with JSON5 specs#43
Open
JuliaGerasymenko wants to merge 12 commits intomasterfrom
Open
Make the JavaScript parser compliant with JSON5 specs#43JuliaGerasymenko wants to merge 12 commits intomasterfrom
JuliaGerasymenko wants to merge 12 commits intomasterfrom
Conversation
JuliaGerasymenko
force-pushed
the
js-parser
branch
from
a321bd2 to
df91e0d
Compare
JuliaGerasymenko
force-pushed
the
js-parser
branch
from
3516389 to
3025f34
Compare
JuliaGerasymenko
force-pushed
the
js-parser
branch
from
0bf7ae8 to
c8bc165
Compare
belochub
requested changes
Apr 24, 2019
JuliaGerasymenko
force-pushed
the
js-parser
branch
from
1382d35 to
2a3c50e
Compare
belochub
requested changes
May 24, 2019
Member
belochub
left a comment
belochub
left a comment
There was a problem hiding this comment.
Some parts of the PR are not very clear to me, and parser is broken for different possible inputs I've provided. You should add tests for those inputs to ensure that they work correctly, before or after fixing the parser.
belochub
reviewed
Jun 6, 2019
belochub
reviewed
Jun 13, 2019
belochub
reviewed
Jun 13, 2019
belochub
approved these changes
Jun 13, 2019
nechaido
reviewed
Jun 14, 2019
SemenchenkoVitaliy
approved these changes
Jun 18, 2019
nechaido
approved these changes
Aug 2, 2020
| // Parse a number | ||
| // | ||
| parseNumber() { | ||
| this.skipClutter(); |
Member
There was a problem hiding this comment.
Each time this function is called clutter is already skipped. Because of this we can drop this line. Although we intend to have this as a part of a public API -- we should keep it. @belochub WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.