install-rose-meta: support git sources#46
Merged
dpmatthews merged 1 commit intometomi:masterfrom Mar 27, 2026
Merged
Conversation
james-bruten-mo
left a comment
james-bruten-mo
left a comment
There was a problem hiding this comment.
Hi Dave, changes look fine, but I think you need to exclude the .github directory as well give um-meta reads from the top level of the clone
| gh repo clone ${GIT_SOURCE} ${GIT_CLONE} -- -q --depth=1 --branch=${BRANCH} | ||
| echo "[INFO] ${PWD}/${GIT_CLONE}: created." | ||
| fi | ||
| LIST="$(find ${GIT_CLONE}/${DIR} -mindepth 1 -maxdepth 1 -not -path "*/.git" \( -type l -xtype d -o -type d \) -printf '%f\n')" |
There was a problem hiding this comment.
Just running this to check, and I noticed it's copied a .github directory into the output directory, I think coming from the um-meta repo as the path is .. It's probably worth adding a -not -path ".github" as well to this line?
Member
Author
There was a problem hiding this comment.
Well spotted - I've changed it to -not -name '.*' which will exclude any hidden directories.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.