Skip to content

Correctly handle recursive schemas in -parser-info - #1234

Merged
mattiuusitalo merged 8 commits into
metosin:masterfrom
frenchy64:parser-info-cycle-detection
Oct 31, 2025
Merged

Correctly handle recursive schemas in -parser-info#1234
mattiuusitalo merged 8 commits into
metosin:masterfrom
frenchy64:parser-info-cycle-detection

Conversation

@frenchy64

@frenchy64 frenchy64 commented Oct 30, 2025

Copy link
Copy Markdown
Collaborator

Fixes metosin/oksa#27

Detects ref cycles by identifying refs by their name+scope. Generalizes a concept from malli.generator, so a shared helper m/-identify-ref-schema seemed appropriate since it's quite handy. It could be used in place of -memoize in :ref's validator. Unfortunately there's no opts arg so dynamic vars might be needed.

GPT-4.1 LLM used for debugging, design, and to generate the basis for the for the :ref -parser-info case (based on -ref-gen).

GPT-4.1 LLM used for debugging, design, and to generate
the basis for the for the (extend-type Object ParserInfo ...) case.
@frenchy64
frenchy64 marked this pull request as ready for review October 30, 2025 18:47
@frenchy64 frenchy64 self-assigned this Oct 30, 2025
@frenchy64 frenchy64 added the bug Something isn't working label Oct 30, 2025

@mattiuusitalo mattiuusitalo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work

@mattiuusitalo
mattiuusitalo merged commit cc95c58 into metosin:master Oct 31, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

java.lang.StackOverflowError in malli 0.20.0-alpha2

3 participants