test-render-scorecard.R: add assertion to prevent subtest skip#87
Merged
test-render-scorecard.R: add assertion to prevent subtest skip#87
Conversation
test-render-scorecard.R has a regression test that checks that render_scorecard doesn't error when called with a relative path. This subtest is skipped as of testthat 3.3.0 (specifically 2e911f4a) because it doesn't have any assertions. Add an assertion that the PDF output file exists so that the subtest is executed. Fixes #85.
barrettk
approved these changes
Jan 15, 2026
Collaborator
barrettk
left a comment
barrettk
left a comment
There was a problem hiding this comment.
Looks good!
You can ignore the (now edited) comment I made on the other PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-render-scorecard.Rhas a regression test that checks thatrender_scorecarddoesn't error when called with a relative path. This subtest is skipped as of testthat 3.3.0 (specifically 2e911f4a) because it doesn't have any assertions.Add an assertion that the PDF output file exists so that the subtest is executed.
Fixes #85.