-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Excel advanced mode preview #2109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6a98288
feat: add Excel advanced mode preview support in preview API and viewer
cursoragent 41b6d88
feat: show preview button for Excel files with advanced mode on docum…
cursoragent 4d3c3e1
feat: add Excel advanced mode preview to dataroom document management
cursoragent 10f30e0
fix: return 200 for non-advanced sheets so PreviewViewer renders inli…
cursoragent File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| export { PreviewExcelViewer } from "./preview-excel-viewer"; | ||
| export { PreviewImageViewer } from "./preview-image-viewer"; | ||
| export { PreviewPagesViewer } from "./preview-pages-viewer"; | ||
| export { PreviewViewer } from "./preview-viewer"; |
58 changes: 58 additions & 0 deletions
58
components/documents/preview-viewers/preview-excel-viewer.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| import { useState } from "react"; | ||
|
|
||
| import { DocumentPreviewData } from "@/lib/types/document-preview"; | ||
| import { cn } from "@/lib/utils"; | ||
|
|
||
| interface PreviewExcelViewerProps { | ||
| documentData: DocumentPreviewData; | ||
| onClose: () => void; | ||
| } | ||
|
|
||
| export function PreviewExcelViewer({ | ||
| documentData, | ||
| onClose, | ||
| }: PreviewExcelViewerProps) { | ||
| const [iframeLoaded, setIframeLoaded] = useState(false); | ||
|
|
||
| const { file, documentName } = documentData; | ||
|
|
||
| if (!file) { | ||
| return ( | ||
| <div className="flex h-full w-full items-center justify-center"> | ||
| <p className="text-gray-400">Excel preview not available</p> | ||
| </div> | ||
| ); | ||
| } | ||
|
|
||
| const embedUrl = `https://view.officeapps.live.com/op/embed.aspx?src=${encodeURIComponent(file)}&wdPrint=0&action=embedview&wdAllowInteractivity=False`; | ||
|
|
||
| return ( | ||
| <div className="relative h-full w-full overflow-hidden"> | ||
| {/* Document Title */} | ||
| <div className="absolute left-1/2 top-4 z-50 -translate-x-1/2"> | ||
| <div className="rounded-lg bg-black/20 px-3 py-2 text-white"> | ||
| <span className="text-sm font-medium">{documentName}</span> | ||
| </div> | ||
| </div> | ||
|
|
||
| {/* Loading indicator */} | ||
| {!iframeLoaded && ( | ||
| <div className="absolute inset-0 flex items-center justify-center"> | ||
| <div className="h-8 w-8 animate-spin rounded-full border-2 border-white border-t-transparent" /> | ||
| </div> | ||
| )} | ||
|
|
||
| {/* Office Online iframe */} | ||
| <div className="h-full w-full pt-14 pb-2 px-2"> | ||
| <iframe | ||
| className={cn( | ||
| "h-full w-full rounded-md transition-opacity duration-200", | ||
| iframeLoaded ? "opacity-100" : "opacity-0", | ||
| )} | ||
| src={embedUrl} | ||
| onLoad={() => setIframeLoaded(true)} | ||
| /> | ||
| </div> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Guard
advancedDistributionHostbefore building the preview URL.getTeamStorageConfigById()returns a config whereadvancedDistributionHostis optional, so this can emithttps://undefined/...and silently break advanced Excel previews for teams without that distribution configured.Suggested fix
if (!primaryVersion.file.includes("https://")) { const storageConfig = await getTeamStorageConfigById(document.teamId); + if (!storageConfig.advancedDistributionHost) { + return res.status(503).json({ + message: + "Advanced Excel preview is not configured for this team.", + }); + } returnData.file = `https://${storageConfig.advancedDistributionHost}/${primaryVersion.file}`; } else {📝 Committable suggestion
🤖 Prompt for AI Agents