SDL: Exit the application when the escape key is pressed#1407
Open
ccawley2011 wants to merge 1 commit intomgba-emu:masterfrom
Open
SDL: Exit the application when the escape key is pressed#1407ccawley2011 wants to merge 1 commit intomgba-emu:masterfrom
ccawley2011 wants to merge 1 commit intomgba-emu:masterfrom
Conversation
Member
|
I just checked this with a current build running on Ubuntu 19.10. It seems that - at least for me - pressing the ESC key has no effect. Maybe this is limited to SDL1? |
Member
|
The reason I never merged this was because hitting escape by mistake and then losing everything unsaved has happened to me far too many times for me to think this is a good idea. |
|
What if instead of a single escape press it was multiple or duration based to alleviate accidental quits? |
|
Or just use alt-f4 for both sdl1 and sdl2? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While SDL2 will quit the application when Alt+F4 is pressed, SDL1 does not. This makes it difficult to exit the application when it was started in full-screen.
This was tested with Linux and X11, although this behavior may differ on other platforms.