You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This looks great, thanks @mathewmeconry! However there appears to be a merge conflict preventing me from merging, in package-lock.json of all places. The weird thing is that this repo does not have a lockfile at all.
Hey @mtimofiiv
Thanks for the review.
I fixed the conflict and updated my branch with your master.
You should consider adding the package-lock.json to the repo. Because then the package versions of your dependencies are fixed and don't have unwanted side effects when newer versions are downloaded.
Hi @mtimofiiv
Some time has passed and I wanted to check in if you can merge this now or if there are any other issues
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in pull #15 I created a new pull