Skip to content

Update/Add miscellaneous things: - #23

Merged
micahmo merged 2 commits into
micahmo:masterfrom
jasper-186:miscellaneous_changes
Sep 22, 2026
Merged

micahmo merged 2 commits into
micahmo:masterfrom
jasper-186:miscellaneous_changes

Conversation

@jasper-186

Copy link
Copy Markdown
  • Update to net10 framework from net6
  • Update TwithLib API to 3.10.2
  • Remove System.Net.Http.Json package reference
  • Create a virtual environment for python to install pip packages into(instead of trying to install them as system packages)
  • Replace youtube-dl with yt-dlp
  • Add STREAMLINK_QUALITY environment Variable
  • Update README to explain new variable

- Update to net10 framework from net6
- Update TwithLib API to 3.10.2
- Remove System.Net.Http.Json packagereference
- Create a virtual environment for python to install pip packages into
- Replace youtube-dl with yt-dlp
- Add STREAMLINK_QUALITY Environment Variable

@micahmo micahmo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey thank you so much for these changes! I haven't really maintained twitch2tuner in a while, but these all seem like good upgrades. Please take a look at the few comments I left.

Comment thread twitch2tuner/Config.cs
Comment thread twitch2tuner/StreamUtility.cs
Comment thread twitch2tuner/StreamUtility.cs Outdated
Comment thread Dockerfile Outdated
Comment thread twitch2tuner/StreamUtility.cs
Comment thread README.md Outdated
Comment thread twitch2tuner/Program.cs Outdated
Comment thread twitch2tuner/Tuner.cs Outdated
Comment thread docker-template/twitch2tuner.xml
- Fixed a bunch of comments still citing "Youtube-dl" instead of the new "Yt-dlp"
- removed comments in Dockerfile
- Removed Experimental "low-latency" flag
- Update docker XML for new environment variable
- Allow for backwards compatibility by having "YOUTUBE_DL" point at the new yt-dlp instance
- Prevent "STREAMLINK_QUALITY" from being empty.

@micahmo micahmo left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates, nice work! Will merge and run a new container build.

@micahmo
micahmo merged commit c3b4cea into micahmo:master Sep 22, 2026
@micahmo

micahmo commented Sep 22, 2026

Copy link
Copy Markdown
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants