Skip to content

fix(php): fix compatibility issue with php 8.1 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 1.4.x
Choose a base branch
from
Open

fix(php): fix compatibility issue with php 8.1 #61

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
de3fa87
fix(php): fix compatibility issue with php 8.1
kduret Jul 28, 2022
dedffe1
Update src/VirtualFileSystem/Wrapper/FileHandler.php
kduret Sep 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/VirtualFileSystem/Wrapper/FileHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function atEof()
public function truncate($newSize = 0)
{
$this->position(0);
$newData = substr($this->file->data(), 0, $newSize);
$newData = substr($this->file->data() ? $this->file->data() : '', 0, $newSize);
Copy link

@slashrsm slashrsm Oct 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this fixes the issue. Maybe we could use null coalescing operator?

$newData = false === $newData ? '' : $newData;
$this->file->setData($newData);
$this->file->setModificationTime(time());
Expand Down