Preserve dock opacity when draging window preview in shell overview#1804
Open
yellowgh0st wants to merge 1 commit intomicheleg:ubuntu-dockfrom
Open
Preserve dock opacity when draging window preview in shell overview#1804yellowgh0st wants to merge 1 commit intomicheleg:ubuntu-dockfrom
yellowgh0st wants to merge 1 commit intomicheleg:ubuntu-dockfrom
Conversation
Collaborator
|
Mh, personally I think it makes sense to make it opaque in case it was not to make clear that such operation has not to be performed on dock. You can make it an option, but in general this should happen IMHO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to maintain visual rhythm, symmetry and consistency I suggest this change that preserves dock opacity during the window preview drag user event.
With this change, the workspace body that allows user to drop the window on to workspace or go to desired workspace by click, gets on both left and right sides visually equal width. I say visually because technically the workspace bodies still differ
because the part of the left one is being hidden under the dock.
During the drag event dock doesn't provide any functionality and it actually prevents dropping the window which can be confusing when is transparent.
By leaving the dock's opacity same as is top bar's we achieve even more consistency.